37672[BUGFIX] Respect newlines in ['SYS']['binSetup']
Commit message
Review
-
Code review CR +2
- Nicole Hummel +2
- Markus Klein +1
- Wouter Wolters +1
-
Verified V +2
- Nicole Hummel +2
- Markus Klein +1
Issues 1
Files 2
Review log 11
-
Nicole Hummel uploaded patch set 1 03/09/15, 15:57
-
Markus Klein updated the commit message in patch set 2 03/09/15, 16:33
-
Markus Klein commented on patch set 2 03/09/15, 16:35
can we add a unit test for this. I'm almost sure, we will break that again in the future by accident ^^ -
Tymoteusz Motylewski commented on patch set 2 CR -1 03/09/15, 16:48
working on unit tests, will push a followup in a moment -
Tymoteusz Motylewski uploaded patch set 3 03/09/15, 17:35
-
Markus Klein commented on patch set 3 03/09/15, 17:41
nitpicks, will fixCommandUtilityTest.php:33spaceCommandUtilityTest.php:34tab -
Markus Klein uploaded patch set 4 03/09/15, 17:46
-
Markus Klein voted on patch set 4 CR +1 V +1 03/09/15, 17:47
-
Wouter Wolters voted on patch set 4 CR +1 03/09/15, 17:49
-
Nicole Hummel voted on patch set 4 CR +2 V +2 03/09/15, 20:34
-
Nicole Hummel merged patch set 4 03/09/15, 20:34