Review main Merged

37672[BUGFIX] Respect newlines in ['SYS']['binSetup']

Nicole Hummel CR +2 V +2 Normal +92 −2 updated 03/09/15, 20:34

Commit message

If you separate the list of programs by new line (as suggested in the
Install Tool description), the programs aren't found.
The problem is that the newline is saved as string component by
the Install Tool. Therefore the new line separator (LF) has to
be replaced before splitting the value.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Nicole Hummel +2
    • Markus Klein +1

Issues 1

Files 2

Review log 11

  1. Nicole Hummel uploaded patch set 1 03/09/15, 15:57

  2. Markus Klein updated the commit message in patch set 2 03/09/15, 16:33

  3. Markus Klein commented on patch set 2 03/09/15, 16:35

    can we add a unit test for this. I'm almost sure, we will break that again in the future by accident ^^
  4. Tymoteusz Motylewski commented on patch set 2 CR -1 03/09/15, 16:48

    working on unit tests, will push a followup in a moment
  5. Tymoteusz Motylewski uploaded patch set 3 03/09/15, 17:35

  6. Markus Klein commented on patch set 3 03/09/15, 17:41

    nitpicks, will fix

    CommandUtilityTest.php:33

    space

    CommandUtilityTest.php:34

    tab
  7. Markus Klein uploaded patch set 4 03/09/15, 17:46

  8. Markus Klein voted on patch set 4 CR +1 V +1 03/09/15, 17:47

  9. Wouter Wolters voted on patch set 4 CR +1 03/09/15, 17:49

  10. Nicole Hummel voted on patch set 4 CR +2 V +2 03/09/15, 20:34

  11. Nicole Hummel merged patch set 4 03/09/15, 20:34