Review main Merged

37689[TASK] Disallow shutdown of own backend account

Andreas Kienast CR +2 V +2 Normal +41 −22 updated 03/10/15, 18:47

Commit message

It's not possible to delete or disable one's own backend
user account in the list module anymore.

Review

  • Code review CR +2
    • Markus Klein +2
    • Nicole Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Nicole Hummel +1

Issues 1

Files 1

Review log 13

  1. Andreas Kienast uploaded patch set 1 03/10/15, 07:48

  2. Andreas Kienast uploaded patch set 2 03/10/15, 07:49

  3. Nicole Hummel voted on patch set 2 CR +1 03/10/15, 07:52

  4. Nicole Hummel voted on patch set 2 V +1 03/10/15, 08:37

  5. Markus Klein commented on patch set 2 CR +1 03/10/15, 09:40

    hm, actually such functionality would belong into a hook and not the "generic listing" utility. But maybe it's an overkill to add a hook for every button here, so fine with me.
  6. Andreas Wolf updated the commit message in patch set 3 03/10/15, 10:09

  7. Andreas Wolf voted on patch set 3 CR +2 03/10/15, 10:10

  8. Nicole Hummel voted on patch set 3 CR +1 V +1 03/10/15, 10:12

  9. Markus Klein updated the commit message in patch set 4 03/10/15, 10:35

  10. Markus Klein voted on patch set 4 CR +1 03/10/15, 10:36

  11. Nicole Hummel voted on patch set 4 CR +1 V +1 03/10/15, 10:38

  12. Markus Klein voted on patch set 4 CR +2 V +2 03/10/15, 18:47

  13. Markus Klein merged patch set 4 03/10/15, 18:47