Review main Merged

37730[BUGFIX] Properly handle absolute links in typolink()

Markus Klein CR +2 V +2 Easy +1 −1 updated 03/11/15, 14:40

Commit message

Fix a wrong assumption in the code that claims we link across domains.
If config.forceAbsoluteUrl is set, we might link to the same domain.

The patch adds a check, such that the assumption is correct afterwards.

Review

  • Code review CR +2
    • Markus Klein +2
    • Mathias Schreiber +1
    • Andreas Kienast +1
  • Verified V +2
    • Markus Klein +2
    • Mathias Schreiber +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 6

  1. Markus Klein uploaded patch set 1 03/11/15, 14:18

  2. Mathias Schreiber voted on patch set 1 CR +1 V +1 03/11/15, 14:27

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 03/11/15, 14:29

  4. Markus Klein voted on patch set 1 CR +2 V +2 03/11/15, 14:39

  5. Markus Klein merged patch set 1 03/11/15, 14:39

  6. Markus Klein commented on patch set 2 03/11/15, 14:40

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit ceed649f532998139a1a3ff7a53011fa8dbc1344