Review main Merged

37764[TASK] Speed and clean up RecordsContentObject

Wouter Wolters CR +2 V +2 Easy +15 −13 updated 03/12/15, 15:56

Commit message

* Initialize variables only when needed
* Use empty instead of count
* Set count once and use a variable instead
* Import used classes

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stephan Großberndt +1
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1

Issues 1

Files 1

Review log 8

  1. Wouter Wolters uploaded patch set 1 03/11/15, 23:06

  2. Markus Klein voted on patch set 1 CR +1 03/11/15, 23:15

  3. Stephan Großberndt voted on patch set 1 CR +1 03/11/15, 23:24

  4. Markus Klein uploaded patch set 2 03/12/15, 00:34

  5. Markus Klein voted on patch set 2 CR +1 V +1 03/12/15, 00:35

  6. Stephan Großberndt voted on patch set 2 CR +1 03/12/15, 12:19

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 03/12/15, 15:56

  8. Christian Kuhn merged patch set 2 03/12/15, 15:56