Review main Merged

37798[TASK] Use ::class instead of strings

Frank Nägler CR +2 V +2 Easy +4 −4 updated 03/15/15, 15:40

Commit message

In some cases makeInstance is used with strings instead
of ::class. This patch fix it.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stephan Großberndt +1
    • Frank Nägler +1
    • Michael Oehlhof +1
  • Verified V +2
    • Markus Klein +2
    • Frank Nägler +1

Issues 1

Files 4

Review log 12

  1. Frank Nägler uploaded patch set 1 03/12/15, 19:29

  2. Nicole Hummel voted on patch set 1 CR +1 03/12/15, 19:46

  3. Wouter Wolters voted on patch set 1 CR +1 03/12/15, 19:49

  4. Markus Klein voted on patch set 1 CR +1 V +1 03/12/15, 23:34

  5. Stephan Großberndt commented on patch set 1 03/15/15, 13:49

    I dont want to reset the votes but there is a typo in the commit message. It should be makeInstance, not makeInstace.
  6. Stephan Großberndt voted on patch set 1 CR +1 03/15/15, 13:51

  7. Frank Nägler updated the commit message in patch set 2 03/15/15, 14:07

  8. Frank Nägler commented on patch set 2 V +1 CR +1 03/15/15, 14:07

    only commit messages updated, please re-vote
  9. Stephan Großberndt voted on patch set 2 CR +1 03/15/15, 14:13

  10. Michael Oehlhof voted on patch set 2 CR +1 03/15/15, 14:55

  11. Markus Klein voted on patch set 2 CR +2 V +2 03/15/15, 15:40

  12. Markus Klein merged patch set 2 03/15/15, 15:40