Review main Merged

37802[TASK] Use local variable for $GLOBALS in PageRepository

Wouter Wolters CR +2 V +2 Hard +309 −283 updated 03/15/15, 16:02

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Markus Klein +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Klein +1

Issues 1

Files 1

Review log 6

  1. Wouter Wolters uploaded patch set 1 03/12/15, 22:52

  2. Markus Klein commented on patch set 1 03/12/15, 23:20

    PageGenerator.php:45

    this should be @var <type> $var
  3. Markus Klein uploaded patch set 2 03/12/15, 23:24

  4. Markus Klein commented on patch set 2 CR +1 V +1 03/12/15, 23:26

    Now we need one more cleanup to fix the dynamically declared TSFE properties
  5. Frank Nägler voted on patch set 2 V +2 CR +2 03/15/15, 16:02

  6. Frank Nägler merged patch set 2 03/15/15, 16:02