37819[FOLLOWUP] Do not respect autoload info if core repo is composer root
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Mathias Schreiber +1
- Wouter Wolters +1
- Alexander Stehlik +1
- Mathias Brodala +1
-
Verified V +2
- Helmut Hummel +2
- Mathias Schreiber +1
Issues 1
Files 1
Review log 15
-
Helmut Hummel uploaded patch set 1 03/13/15, 13:27
-
Alexander Stehlik commented on patch set 1 CR +1 03/13/15, 13:38
One question: would it be doable from a security perspective to allow setting a custom path in the environment variable? I'm not sure how easy environment variables can be manipulated though. -
Mathias Brodala commented on patch set 1 03/13/15, 13:56
I agree with Alexander. For custom directory setups it would be useful to override the path which is looked for. Currently you'd have to manually include the Composer autoloader before TYPO3 bootstrap starts. -
Helmut Hummel commented on patch set 1 03/13/15, 13:59
I would absolutely would *not* make this configurable! We would end up having to support a range of setups we did not even think of and it could very likely be that we diverge from standard composer, which is the contrary of what we re currently working on. -
Mathias Brodala commented on patch set 1 03/13/15, 14:01
I understand what you mean but the need for a custom path arises actually since the typo3/cms currently diverges from the Composer standards. Having typo3/cms in vendor-dir for example makes it necessary to teach it about the autoloader location. -
Alexander Stehlik commented on patch set 1 03/13/15, 14:01
Hmm, OK, I see your point. Could we then at least add a path to the list that works when TYPO3 is installed as a library (e.g. in Packages/Libraries/typo3/cms/)? -
Alexander Stehlik commented on patch set 1 03/13/15, 14:02
I'm too slow ;) -
Helmut Hummel commented on patch set 1 03/13/15, 14:04
correct. If anything, we must read the location of the vendor dir from composer.json But then the TYPO3 PackageManager also must do so to be fully interoperable. I would rather not support this, until all other TYPO3 / composer interoperability issues are resolved, because this adds another layer of complexity and I strive to reduce it first and then see if we can afford more complexity again in this area -
Mathias Brodala commented on patch set 1 CR +1 03/13/15, 14:06
You're right, let's tackle this with 7.3. ;-) -
Helmut Hummel voted on patch set 1 CR +2 V +2 03/13/15, 14:11
-
Alexander Stehlik commented on patch set 1 03/13/15, 14:11
I'm not quite sure where the problem with the TYPO3 package manager is. I'm running TYPO3 6.2 in Packages/Libraries/typo3/cms for some time now and did not have any problems. The only thing I changed for this is the composer install script (see https://github.com/Intera/typo3-cms-composer-installers/tree/feature/minimalcoreinstall) and this: https://github.com/Intera/TYPO3.CMS/commit/ecb921811fd04844a884f812ee9fde09885096ed But this is probably nothing we should officially backport to 6.2, maintenance would be too much hassle ;) -
Mathias Schreiber voted on patch set 1 CR +1 V +1 03/13/15, 14:11
-
Wouter Wolters voted on patch set 1 CR +1 03/13/15, 14:12
-
Helmut Hummel commented on patch set 1 03/13/15, 14:13
thank you folks! -
Helmut Hummel merged patch set 1 03/13/15, 14:13