37839[!!!][BUGFIX] Do not disclose local path of file in TS
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Anja Leichsenring +1
-
Verified V +2
- Markus Klein +2
- Anja Leichsenring +1
Issues 1
Files 2
Review log 24
-
Benni Mack uploaded patch set 1 03/14/15, 10:31
-
Frans Saris voted on patch set 1 CR +1 03/14/15, 11:07
-
Markus Klein commented on patch set 1 03/14/15, 12:04
The question for me is, where do you need localPath at all in FE rendering? (The core does not use it) I suspect you only need it, if you intend to play around with the file somehow. Having this set to read-only now, provides direct access to the original file, so any code using this, should be aware that changing the file will totally harm the consistency of the FAL data, the index will be outdated. Can we expect people to know that? -
Frans Saris commented on patch set 1 03/14/15, 15:40
Imo we can as this is just a "replacement" of the same functionality as before FAL were you also had always the path to the original file. Can not come up with a use case where on every run/page load the original file is overwritten. -
Markus Klein commented on patch set 1 03/14/15, 15:46
What would be a usecase to use localPath? Something in combination with Gifbuilder? -
Frans Saris commented on patch set 1 03/14/15, 16:10
I guess mainly userfunc stuff that doesn't support FAL yet and indeed GIFBUILDER. Maybe Benni has some other use-cases -
Benni Mack commented on patch set 1 03/15/15, 16:09
I don't see a reason for using that option at all TBH (otherwise more people would have complained that the real file name does not get used at all) -
Markus Klein commented on patch set 1 03/15/15, 18:11
Then I'd suggest to drop that option to strictly avoid misuse. -
Frans Saris commented on patch set 1 03/16/15, 07:25
Adjust for 6.2 and drop or deprecate for master? -
Markus Klein commented on patch set 1 03/16/15, 14:03
I suggest to adjust for 6.2 and drop for master -
Georg Ringer voted on patch set 1 CR +1 V +1 03/27/15, 21:38
-
Markus Klein commented on patch set 1 CR -1 03/27/15, 22:06
Drop for master! -
Markus Klein commented on patch set 1 03/28/15, 01:02
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 3844b6e671aee993d68c3aed4fc721b130b44760 -
Markus Klein uploaded patch set 2 03/28/15, 01:12
-
Markus Klein voted on patch set 2 CR +1 V +1 03/28/15, 01:13
-
Frans Saris commented on patch set 2 03/28/15, 06:11
Shouldn't the commit message be adjusted? -
Markus Klein updated the commit message in patch set 3 03/28/15, 08:23
-
Frans Saris updated the commit message in patch set 4 03/28/15, 08:39
-
Frans Saris voted on patch set 4 CR +1 03/28/15, 08:40
-
Andreas Kienast updated the commit message in patch set 5 03/28/15, 09:06
-
Anja Leichsenring commented on patch set 5 03/28/15, 09:40
Decision in the end: fix for 6.2 and drop option for master. This is current state. -
Anja Leichsenring voted on patch set 5 CR +1 V +1 03/28/15, 10:06
-
Markus Klein voted on patch set 5 CR +2 V +2 03/28/15, 10:08
-
Markus Klein merged patch set 5 03/28/15, 10:08