Review main Merged

37843[TASK] Remove initialization for fileFactory in AbstractContentObject

Wouter Wolters CR +2 V +2 Easy +24 −12 updated 03/15/15, 17:48

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Stephan Großberndt +1
  • Verified V +2
    • Markus Klein +2
    • Stephan Großberndt +1

Issues 1

Files 4

Review log 13

  1. Wouter Wolters uploaded patch set 1 03/14/15, 16:35

  2. Markus Klein commented on patch set 1 03/14/15, 18:29

    ImageTextContentObject.php:502

    shorten the namespaces
  3. Markus Klein uploaded patch set 2 03/14/15, 18:30

  4. Markus Klein commented on patch set 2 CR +2 V +2 03/14/15, 18:31

    ready for merge.. no-brainer
  5. Stephan Großberndt uploaded patch set 3 03/15/15, 17:10

  6. Stephan Großberndt commented on patch set 2 03/15/15, 17:10

    added missing newline before use statement in imagetextcontentobject
  7. Stephan Großberndt voted on patch set 3 CR +1 03/15/15, 17:10

  8. Markus Klein voted on patch set 3 CR +2 V +1 03/15/15, 17:37

  9. Stephan Großberndt voted on patch set 3 V +1 03/15/15, 17:37

  10. Markus Klein voted on patch set 3 V +2 03/15/15, 17:38

  11. Markus Klein merged patch set 3 03/15/15, 17:38

  12. Christian Kuhn commented on patch set 4 03/15/15, 17:46

    ImageTextContentObject.php:503

    public?
  13. Markus Klein commented on patch set 4 03/15/15, 17:48

    ImageTextContentObject.php:503 Reply

    damn... of course not. followup coming along