Review main Merged

37848[TASK] Centralize duplicated SpriteManagerIconViewHelper

Frank Nägler CR +2 V +2 Normal +31 −81 updated 03/15/15, 15:39

Commit message

This patch removes the SpriteManagerIconViewHelper (duplicated with
#65111) from EXT:beuser and changes the templates to use the original
one from EXT:backend.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stephan Großberndt +1
  • Verified V +2
    • Markus Klein +2
    • Stephan Großberndt +1

Issues 1

Files 7

Review log 7

  1. Frank Nägler uploaded patch set 1 03/14/15, 23:18

  2. Markus Klein voted on patch set 1 CR +1 03/15/15, 00:48

  3. Michael Oehlhof commented on patch set 1 CR +1 03/15/15, 02:15

    Edit.html:2

    The namespace bu is no longer used in this template and can be removed.
  4. Stephan Großberndt uploaded patch set 2 03/15/15, 15:25

  5. Stephan Großberndt voted on patch set 2 CR +1 V +1 03/15/15, 15:26

  6. Markus Klein voted on patch set 2 CR +2 V +2 03/15/15, 15:39

  7. Markus Klein merged patch set 2 03/15/15, 15:39