Review main Merged

37849[CLEANUP] EXT:backend/Classes/Controller/*.php

Michael Oehlhof CR +2 V +2 Expert +715 −404 updated 06/18/15, 20:38

Commit message

Refactor the code to go green in PHPStorm.

- declare missing class variables
- add getter for LanguageService
- add getter for BackendUser
- add getter for TimeTracker
- add getter for DocumentTemplate
- add getter for DatabaseConnection
- fix code style issues "Unnecessary fully qualified name"

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 17

Review log 28

Show 3 earlier messages
  1. Michael Oehlhof uploaded patch set 1 03/15/15, 01:58

  2. Michael Oehlhof updated the commit message in patch set 2 03/15/15, 02:23

  3. Christian Kuhn commented on patch set 2 CR -1 03/15/15, 15:13

    please please please, do not merge this now. i'm in a heavy code refactoring of the form stuff at the moment basically touching lots of stuff within ext:backend. It would be very nice to not do cleanups here currently since this could easily end up in merge hell for me and I'm really moving tons of stuff with lots of spent hours on it around.
  1. Michael Oehlhof uploaded patch set 3 04/28/15, 21:10

  2. Jan Helke commented on patch set 3 CR -1 V -1 04/30/15, 10:14

    Broken rebase
  3. Jan Helke commented on patch set 3 04/30/15, 10:16

    EditDocumentController.php:723

    Broken merge

    EditDocumentController.php:853

    Method does not exist anymore.
  4. Jan Helke commented on patch set 3 04/30/15, 10:24

    LoginController.php:449

    Broken merge
  5. Michael Oehlhof uploaded patch set 4 04/30/15, 12:01

  6. Michael Oehlhof uploaded patch set 5 05/02/15, 17:40

  7. Michael Oehlhof uploaded patch set 6 05/06/15, 17:28

  8. Michael Oehlhof commented on patch set 6 05/06/15, 17:29

    Resolved merge conflicts.
  9. Michael Oehlhof uploaded patch set 7 05/16/15, 09:51

  10. Michael Oehlhof commented on patch set 7 05/16/15, 09:52

    Resolved merge conflicts.
  11. Michael Oehlhof uploaded patch set 8 05/26/15, 22:05

  12. Michael Oehlhof commented on patch set 8 05/26/15, 22:07

    Done again, resolved merge conflicts.
  13. Stephan Großberndt uploaded patch set 9 06/17/15, 21:42

  14. Stephan Großberndt commented on patch set 9 06/17/15, 21:42

    rebased
  15. Markus Klein commented on patch set 9 CR -1 06/17/15, 22:06

    BackendController.php:96

    variable not used anymore

    BackendLayoutWizardController.php:65

    unused in Core! remove it

    LoginController.php:246

    no this is a comment for the next if

    LoginController.php:450

    CGL says no space here

    PageLayoutController.php:275

    is bool usage only

    PageLayoutController.php:280

    that's array

    index.php:2

    why adding a namespace here?
  16. Markus Klein uploaded patch set 10 06/17/15, 22:14

  17. Markus Klein voted on patch set 10 CR +1 V +1 06/17/15, 22:15

  18. Michael Oehlhof voted on patch set 10 CR +1 06/18/15, 16:41

  19. Markus Klein commented on patch set 10 CR -1 V 0 06/18/15, 18:05

    I found more to clean up. will push an update
  20. Markus Klein uploaded patch set 11 06/18/15, 18:29

  21. Markus Klein commented on patch set 11 CR -1 06/18/15, 18:56

    one more round

    BackendController.php:888

    not used

    FileSystemNavigationFrameController.php:71

    bool

    FileSystemNavigationFrameController.php:73

    must be public

    LoginController.php:505

    useless move
  22. Markus Klein uploaded patch set 12 06/18/15, 18:57

  23. Markus Klein voted on patch set 12 CR +1 V +1 06/18/15, 18:57

  24. Wouter Wolters voted on patch set 12 V +2 CR +2 06/18/15, 20:38

  25. Wouter Wolters merged patch set 12 06/18/15, 20:38