37849[CLEANUP] EXT:backend/Classes/Controller/*.php
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 17
- typo3/sysext/backend/Classes/Controller/BackendController.php2+101 −62
- typo3/sysext/backend/Classes/Controller/BackendLayoutWizardController.php1+0 −2
- typo3/sysext/backend/Classes/Controller/ClickMenuController.php+20 −8
- typo3/sysext/backend/Classes/Controller/DummyController.php+11 −2
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php2+125 −66
- typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php2+24 −9
- typo3/sysext/backend/Classes/Controller/ListFrameLoaderController.php+20 −4
- typo3/sysext/backend/Classes/Controller/LoginController.php4+9 −4
- typo3/sysext/backend/Classes/Controller/LoginFramesetController.php+15 −3
- typo3/sysext/backend/Classes/Controller/LogoutController.php+17 −4
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+55 −41
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php2+227 −143
- typo3/sysext/backend/Classes/Controller/PageTreeNavigationController.php+52 −25
- typo3/sysext/backend/Classes/Controller/SimpleDataHandlerController.php+31 −22
- typo3/sysext/backend/Classes/Controller/UserSettingsController.php+2 −1
- typo3/sysext/backend/Classes/Tree/View/FolderTreeView.php+5 −0
- typo3/sysext/version/Classes/Hook/DataHandlerHook.php+1 −8
Review log 28
Show 3 earlier messages
-
Michael Oehlhof uploaded patch set 1 03/15/15, 01:58
-
Michael Oehlhof updated the commit message in patch set 2 03/15/15, 02:23
-
Christian Kuhn commented on patch set 2 CR -1 03/15/15, 15:13
please please please, do not merge this now. i'm in a heavy code refactoring of the form stuff at the moment basically touching lots of stuff within ext:backend. It would be very nice to not do cleanups here currently since this could easily end up in merge hell for me and I'm really moving tons of stuff with lots of spent hours on it around.
-
Michael Oehlhof uploaded patch set 3 04/28/15, 21:10
-
Jan Helke commented on patch set 3 CR -1 V -1 04/30/15, 10:14
Broken rebase -
Jan Helke commented on patch set 3 04/30/15, 10:16
EditDocumentController.php:723Broken mergeEditDocumentController.php:853Method does not exist anymore. -
Jan Helke commented on patch set 3 04/30/15, 10:24
LoginController.php:449Broken merge -
Michael Oehlhof uploaded patch set 4 04/30/15, 12:01
-
Michael Oehlhof uploaded patch set 5 05/02/15, 17:40
-
Michael Oehlhof uploaded patch set 6 05/06/15, 17:28
-
Michael Oehlhof commented on patch set 6 05/06/15, 17:29
Resolved merge conflicts. -
Michael Oehlhof uploaded patch set 7 05/16/15, 09:51
-
Michael Oehlhof commented on patch set 7 05/16/15, 09:52
Resolved merge conflicts. -
Michael Oehlhof uploaded patch set 8 05/26/15, 22:05
-
Michael Oehlhof commented on patch set 8 05/26/15, 22:07
Done again, resolved merge conflicts. -
Stephan Großberndt uploaded patch set 9 06/17/15, 21:42
-
Stephan Großberndt commented on patch set 9 06/17/15, 21:42
rebased -
Markus Klein commented on patch set 9 CR -1 06/17/15, 22:06
BackendController.php:96variable not used anymoreBackendLayoutWizardController.php:65unused in Core! remove itLoginController.php:246no this is a comment for the next ifLoginController.php:450CGL says no space herePageLayoutController.php:275is bool usage onlyPageLayoutController.php:280that's arrayindex.php:2why adding a namespace here? -
Markus Klein uploaded patch set 10 06/17/15, 22:14
-
Markus Klein voted on patch set 10 CR +1 V +1 06/17/15, 22:15
-
Michael Oehlhof voted on patch set 10 CR +1 06/18/15, 16:41
-
Markus Klein commented on patch set 10 CR -1 V 0 06/18/15, 18:05
I found more to clean up. will push an update -
Markus Klein uploaded patch set 11 06/18/15, 18:29
-
Markus Klein commented on patch set 11 CR -1 06/18/15, 18:56
one more roundBackendController.php:888not usedFileSystemNavigationFrameController.php:71boolFileSystemNavigationFrameController.php:73must be publicLoginController.php:505useless move -
Markus Klein uploaded patch set 12 06/18/15, 18:57
-
Markus Klein voted on patch set 12 CR +1 V +1 06/18/15, 18:57
-
Wouter Wolters voted on patch set 12 V +2 CR +2 06/18/15, 20:38
-
Wouter Wolters merged patch set 12 06/18/15, 20:38