37856[BUGFIX] Replace uniqid() usages in Tests
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Frank Nägler +1
- Michael Oehlhof +1
-
Verified V +2
- Markus Klein +2
- Frank Nägler +1
- Michael Oehlhof +1
Issues 1
Files 3
Review log 13
-
Stephan Großberndt uploaded patch set 1 03/15/15, 13:34
-
Stephan Großberndt commented on patch set 1 03/15/15, 14:57
Build passed: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/54448907 -
Michael Oehlhof commented on patch set 1 V +1 03/15/15, 15:02
Uni tests OK, but 1 missing \ in phpdoc comment.ActionService.php:62Missing \ at the beginning -
Stephan Großberndt uploaded patch set 2 03/15/15, 15:33
-
Stephan Großberndt uploaded patch set 3 03/15/15, 15:38
-
Frank Nägler voted on patch set 3 V +1 CR +1 03/15/15, 15:45
-
Stephan Großberndt commented on patch set 3 03/15/15, 15:49
-
Michael Oehlhof voted on patch set 3 CR +1 V +1 03/15/15, 15:50
-
Markus Klein commented on patch set 3 CR +1 V +1 03/15/15, 16:01
does this work on windows too? -
Frank Nägler commented on patch set 3 03/15/15, 16:15
the method `$this->getUniqueId` is used several times in the class. I think it should work. -
Stephan Großberndt commented on patch set 3 03/15/15, 17:14
I introduced BaseTestCase->getUniqueId() especially for Windows and also to align uniqid() usage. -
Markus Klein voted on patch set 3 CR +2 V +2 03/15/15, 18:19
-
Markus Klein merged patch set 3 03/15/15, 18:19