Review main Merged

37856[BUGFIX] Replace uniqid() usages in Tests

Stephan Großberndt CR +2 V +2 Easy +5 −5 updated 03/15/15, 18:19

Commit message

Replace usage of uniqid() with BaseTestCase->getUniqueId() and correct
method name in comments.

Review

  • Code review CR +2
    • Markus Klein +2
    • Frank Nägler +1
    • Michael Oehlhof +1
  • Verified V +2
    • Markus Klein +2
    • Frank Nägler +1
    • Michael Oehlhof +1

Issues 1

Files 3

Review log 13

  1. Stephan Großberndt uploaded patch set 1 03/15/15, 13:34

  2. Stephan Großberndt commented on patch set 1 03/15/15, 14:57

  3. Michael Oehlhof commented on patch set 1 V +1 03/15/15, 15:02

    Uni tests OK, but 1 missing \ in phpdoc comment.

    ActionService.php:62

    Missing \ at the beginning
  4. Stephan Großberndt uploaded patch set 2 03/15/15, 15:33

  5. Stephan Großberndt uploaded patch set 3 03/15/15, 15:38

  6. Frank Nägler voted on patch set 3 V +1 CR +1 03/15/15, 15:45

  7. Stephan Großberndt commented on patch set 3 03/15/15, 15:49

  8. Michael Oehlhof voted on patch set 3 CR +1 V +1 03/15/15, 15:50

  9. Markus Klein commented on patch set 3 CR +1 V +1 03/15/15, 16:01

    does this work on windows too?
  10. Frank Nägler commented on patch set 3 03/15/15, 16:15

    the method `$this->getUniqueId` is used several times in the class. I think it should work.
  11. Stephan Großberndt commented on patch set 3 03/15/15, 17:14

    I introduced BaseTestCase->getUniqueId() especially for Windows and also to align uniqid() usage.
  12. Markus Klein voted on patch set 3 CR +2 V +2 03/15/15, 18:19

  13. Markus Klein merged patch set 3 03/15/15, 18:19