37875[BUGFIX] UriBuilder has to handle Iterator objects
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Daniel Goerz +1
- Alexander Opitz +1
-
Verified V +2
- Stefan Neufeind +2
- Alexander Opitz +1
Issues 1
Files 2
Review log 15
-
Andreas Allacher uploaded patch set 1 03/16/15, 07:40
-
Andreas Kienast commented on patch set 1 03/16/15, 08:03
-
Andreas Allacher uploaded patch set 2 03/16/15, 09:23
-
Andreas Allacher commented on patch set 2 03/16/15, 09:23
Thanks -
Andreas Kienast voted on patch set 2 CR +1 04/13/15, 08:43
-
Daniel Goerz voted on patch set 2 CR +1 08/06/15, 18:20
-
Christian Kuhn commented on patch set 2 08/06/15, 18:24
iirc, this area is pretty well covered by tests. could we have a look and maybe add some for this case? -
Daniel Goerz uploaded patch set 3 08/10/15, 14:11
-
Daniel Goerz commented on patch set 3 08/10/15, 14:12
Please check the unittests -
Daniel Goerz voted on patch set 3 CR +1 08/12/15, 12:47
-
Alexander Opitz commented on patch set 3 V +1 CR +1 08/12/15, 13:16
Verified by running test. -
Georg Ringer commented on patch set 3 08/12/15, 14:34
UriBuilder.php:754this should be then an elseif? -
Alexander Opitz commented on patch set 3 08/12/15, 14:38
UriBuilder.php:754ReplyNo, otherwise the processing of "} elseif (is_array($argumentValue)) {" some lines down wouldn't do the rest. But yes, not easy to find that fact. -
Stefan Neufeind voted on patch set 3 CR +2 V +2 08/12/15, 19:13
-
Stefan Neufeind merged patch set 3 08/12/15, 19:14
UriBuilder.php:753