Review main Merged

37881[FEATURE] Introduce System Information dropdown item

Andreas Kienast CR +2 V +2 Hard +851 −4 updated 04/01/15, 19:12

Commit message

This patch introduces a new System Information dropdown item that
contains several system information. By default it displays:
* PHP version
* Database version
* Application context
* git revision (if TYPO3 version has "-dev" suffix)
* Operating system

The item list is extendable by the SystemInformationHookInterface.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Markus Klein +1
  • Verified V +2
    • Jigal van Hemert +2
    • Markus Klein +1
    • Frank Nägler +1

Issues 1

Files 19

Review log 36

Show 11 earlier messages
  1. Andreas Kienast uploaded patch set 1 03/16/15, 13:52

  2. Andreas Kienast updated the commit message in patch set 2 03/16/15, 13:52

  3. Andreas Kienast uploaded patch set 3 03/16/15, 13:54

  4. Andreas Kienast uploaded patch set 4 03/16/15, 14:00

  5. Andreas Kienast uploaded patch set 5 03/16/15, 14:05

  6. Markus Klein commented on patch set 4 03/16/15, 14:10

    What I dislike a bit is that we have HTML code in the PHP code again. This means that other extensions will take this as example and will have the HTML in their ext as well. If we need to change the HTML these will break. I opt for a clear interface that only hands the information needed, but rendering should be done in Core only.

    SystemInformationToolbarItem.php:67

    StringUtility::endsWith

    SystemEnvironmentBuilder.php:56

    string[]

    SystemEnvironmentBuilder.php:499

    , TRUE

    locallang_core.xlf:1076

    GIT
  7. Andreas Kienast commented on patch set 4 03/16/15, 14:15

    SystemInformationToolbarItem.php:67 Reply

    Done

    SystemEnvironmentBuilder.php:56 Reply

    Done

    SystemEnvironmentBuilder.php:499 Reply

    Done

    locallang_core.xlf:1076 Reply

    Done
  8. Andreas Kienast uploaded patch set 6 03/16/15, 14:43

  9. Andreas Kienast uploaded patch set 7 03/16/15, 15:29

  10. Mathias Brodala commented on patch set 7 CR -1 03/16/15, 15:43

    Generally +1 but yeah, passing around data to render would be cleaner instead of prepared HTML.

    SystemInformationHookInterface.php:35

    Please introduce an SystemInformationStatus enumeration for these instead.
  11. Andreas Kienast commented on patch set 7 03/16/15, 16:03

    Is \TYPO3\CMS\Backend\Toolbar\Enumeration\SystemInformationStatusEnumeration alright to you?
  1. Mathias Brodala commented on patch set 7 03/16/15, 16:05

    No need for the "Enumeration" suffix but generally yes.
  2. Andreas Kienast uploaded patch set 8 03/16/15, 17:06

  3. Andreas Kienast commented on patch set 8 03/16/15, 17:07

    I made the approach more general by introducing an abstract class that has only the "addItem" method. If that goes in, we can adjust all other classes to use that method as well.
  4. Andreas Kienast uploaded patch set 9 03/16/15, 17:11

  5. Frank Nägler commented on patch set 9 03/16/15, 20:07

    works great, looks great, but I absolutely dislike the HTML code in PHP classes. Can we use a standalone view for the rendering?
  6. Benjamin Kott commented on patch set 9 03/16/15, 20:56

    AbstractToolbarItem.php:35

    do we really need a link here? i think it should only display informations about the current systen.

    _topbar.less:271

    we should not define a color here - please use the css classes for that
  7. Wouter Wolters commented on patch set 9 03/16/15, 21:00

    AbstractToolbarItem.php:20

    useless imports here ;)
  8. Georg Ringer commented on patch set 9 V +1 03/16/15, 21:01

    AbstractToolbarItem.php:54

    for me the link is leading to nowehre,... so why a link?
  9. Andreas Kienast commented on patch set 9 03/17/15, 06:57

    AbstractToolbarItem.php:20 Reply

    copy/paste is not good, mkay? ;)

    AbstractToolbarItem.php:35 Reply

    My idea was to make a more general approach. I thought we can port all other menus to use "addItem()" then, having only one part that handles all the HTML stuff. The link would be required by Cache Menu, Open Docs, Workspaces etc.

    AbstractToolbarItem.php:54 Reply

    It's more like a workaround here so have a consistent layout. I had some ideas what we can do with these "links", but that needs more brainstorming if it makes sense etc.

    _topbar.less:271 Reply

    Unfortunately there is only the "badge" class in twbs. Should we introduce more global classes like "badge-success", "badge-danger" and so on?
  10. Andreas Kienast uploaded patch set 10 03/17/15, 14:47

  11. Andreas Kienast uploaded patch set 11 03/17/15, 14:59

  12. Andreas Kienast uploaded patch set 12 03/31/15, 05:51

  13. Andreas Kienast commented on patch set 12 03/31/15, 05:52

    rebased
  14. Markus Klein commented on patch set 12 CR -1 03/31/15, 09:16

    Very nice thing, but still I'm not yet satisfied ;-)

    AbstractToolbarItem.php:41

    What is this getter good for? If it is used only internally, please do not expose it to the outside.

    SystemInformationToolbarItem.php:130

    you need to check if git is really available! Some use a dev version via the nightly build downloads and have no git available

    locallang.xlf:12

    this is not needed here. There is no linebreaks.

    locallang.xlf:15

    same here.

    locallang.xlf:19

    I would avoid having <br> here. Just use a normal line break and do the LF->br conversion on output.

    SystemInformation.html:2

    just define the extension name in the StandaloneView and you don't need to put the whole path here all the time.

    SystemInformationMenu.js:36

    no need for the extra function wrap

    SystemInformationController.php:31

    shorten

    locallang.xlf:357

    not needed

    ext_localconf.php:5

    combine into a single if

    SystemEnvironmentBuilder.php:476

    I'm almost certain that we already have such a check for disabled functions somewhere. (maybe install tool)

    SystemEnvironmentBuilder.php:476

    shorten

    DatabaseConnection.php:3169

    we usually have no dot at the end
  15. Andreas Kienast commented on patch set 12 03/31/15, 10:31

    SystemEnvironmentBuilder.php:476 Reply

    That's a protected function in there doing more stuff than I need.
  16. Andreas Kienast uploaded patch set 13 03/31/15, 10:31

  17. Andreas Kienast uploaded patch set 14 03/31/15, 10:33

  18. Markus Klein voted on patch set 14 CR +1 03/31/15, 10:46

  19. Xavier Perseguers voted on patch set 14 V +1 03/31/15, 10:53

  20. Xavier Perseguers commented on patch set 14 03/31/15, 19:01

    SystemInformationToolbarItem.php:138

    why do you rely on shell_exec? you could do the same with exec(), which is supposed to be always available and furthermore, Core should use \TYPO3\CMS\Core\Utility\CommandUtility::exec() instead of directly calling exec()

    SystemInformationToolbarItem.php:296

    nitpicking: 2 spaces here

    SystemInformationToolbarItem.php:317

    No need for fully qualified call to GeneralUtility, you aliased it at the top
  21. Andreas Kienast uploaded patch set 15 04/01/15, 17:32

  22. Markus Klein voted on patch set 15 V +1 CR +1 04/01/15, 17:58

  23. Frank Nägler commented on patch set 15 V +1 04/01/15, 18:46

    InformationStatus.php:46

    maybe STATUS_INFO = -1 and STATUS_NOTICE = -2 like for FlashMessages and Modals?
  24. Jigal van Hemert voted on patch set 15 CR +2 V +2 04/01/15, 19:12

  25. Jigal van Hemert merged patch set 15 04/01/15, 19:12