Review main Merged

37897[TASK] Don't define extTarget = _top as default

Benni Mack CR +2 V +2 Easy +2 −9 updated 03/17/15, 11:29

Commit message

In the past, External links not generated via RTE/parseFunc,
e.g. just plain typolink, had the target="_top" attribute, which
in sites without frames is the same as not setting the target.

As frames are extraordinary these days, the default should be
to not set the extTarget at all by default, but let CSS Styled
Content set the extTarget to blank.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Thomas Schlumberger +1
  • Verified V +2
    • Georg Ringer +2
    • Thomas Schlumberger +1

Issues 1

Files 2

Review log 9

  1. Benni Mack uploaded patch set 1 03/17/15, 08:12

  2. Thomas Schlumberger commented on patch set 1 CR +1 V +1 03/17/15, 08:25

    Generally okay, but i think we could remove the "_top" option in the future
  3. Benni Mack commented on patch set 1 03/17/15, 08:44

    Ahhh, you're right. Removing the target="_top" is equal to not setting the target at all if you're not using frames. If you're using frames you still can set the option manually via TS.
  4. Benni Mack commented on patch set 1 CR -1 03/17/15, 08:44

    Will come up with a new version.
  5. Benni Mack uploaded patch set 2 03/17/15, 08:56

  6. Thomas Schlumberger commented on patch set 2 CR +1 V +1 03/17/15, 08:59

    Looks good to me as this reduces the function calls on fully cached pages
  7. Wouter Wolters voted on patch set 2 CR +1 03/17/15, 09:11

  8. Georg Ringer voted on patch set 2 CR +2 V +2 03/17/15, 11:29

  9. Georg Ringer merged patch set 2 03/17/15, 11:29