37897[TASK] Don't define extTarget = _top as default
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Wouter Wolters +1
- Thomas Schlumberger +1
-
Verified V +2
- Georg Ringer +2
- Thomas Schlumberger +1
Issues 1
Files 2
Review log 9
-
Benni Mack uploaded patch set 1 03/17/15, 08:12
-
Thomas Schlumberger commented on patch set 1 CR +1 V +1 03/17/15, 08:25
Generally okay, but i think we could remove the "_top" option in the future -
Benni Mack commented on patch set 1 03/17/15, 08:44
Ahhh, you're right. Removing the target="_top" is equal to not setting the target at all if you're not using frames. If you're using frames you still can set the option manually via TS. -
Benni Mack commented on patch set 1 CR -1 03/17/15, 08:44
Will come up with a new version. -
Benni Mack uploaded patch set 2 03/17/15, 08:56
-
Thomas Schlumberger commented on patch set 2 CR +1 V +1 03/17/15, 08:59
Looks good to me as this reduces the function calls on fully cached pages -
Wouter Wolters voted on patch set 2 CR +1 03/17/15, 09:11
-
Georg Ringer voted on patch set 2 CR +2 V +2 03/17/15, 11:29
-
Georg Ringer merged patch set 2 03/17/15, 11:29