Review main Merged

37902[TASK] Streamline pages table in PageRepository

Benni Mack CR +2 V +2 Normal +24 −48 updated 06/26/15, 06:25

Commit message

Since TYPO3 CMS 6, the TCA is always fully loaded
when using the PageRepository in the Frontend.

This way a lot of hard-coded built-in logic for having
the special handling of the "pages" table is not needed
anymore.

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 13

  1. Benni Mack uploaded patch set 1 03/17/15, 11:35

  2. Benni Mack uploaded patch set 2 06/16/15, 15:17

  3. Benni Mack updated the commit message in patch set 3 06/16/15, 15:30

  4. Christian Kuhn commented on patch set 3 06/16/15, 17:02

    do we need to think about eid here, or do we declare this irrelevant in this context and if eid uses this, it must take care of proper bootstrap on its own anyway?
  5. Benni Mack commented on patch set 3 06/16/15, 17:12

    Eid has initTCA - which is needed anyway if somebody wants to deal with PageRepository in a useful manner.
  6. Benni Mack commented on patch set 3 06/16/15, 17:12

    see EidUtility::initTCA()
  7. Christian Kuhn commented on patch set 3 CR +1 06/20/15, 12:45

    +1 on reading for now, will try to give it a testing shot, soon.
  8. Markus Klein commented on patch set 3 06/21/15, 18:01

    PageRepository.php:849

    should be isset() checked as well
  9. Christian Kuhn uploaded patch set 4 06/25/15, 22:18

  10. Christian Kuhn voted on patch set 4 CR +1 V +1 06/25/15, 22:18

  11. Markus Klein voted on patch set 4 CR +2 V +2 06/26/15, 00:39

  12. Markus Klein merged patch set 4 06/26/15, 00:41

  13. Christian Kuhn commented on patch set 5 06/26/15, 06:25