Review main Merged

37945[TASK] Remove version number from generator tag

Wouter Wolters CR +2 V +2 Easy +10 −10 updated 06/15/15, 09:54

Commit message

This change will not increase the security of TYPO3 CMS.
This information can be misused by an attacker for a more targeted attack.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Andreas Kienast +1
  • Verified V +2
    • Helmut Hummel +2
    • Andreas Kienast +1

Issues 1

Files 3

Review log 23

  1. Wouter Wolters uploaded patch set 1 03/19/15, 10:04

  2. Anja Leichsenring commented on patch set 1 05/04/15, 12:49

    I would say this is a feature, and even if not, a feature rst would be very helpful on this new setting. Like the patch, nontheless.
  3. Anja Leichsenring uploaded patch set 2 05/04/15, 12:57

  4. Anja Leichsenring commented on patch set 2 05/04/15, 12:59

    rst file still missing, comming in now.
  5. Markus Klein commented on patch set 2 CR -1 05/04/15, 13:04

    no option here. we have no benefit of having a branch version listed.
  6. Anja Leichsenring uploaded patch set 3 05/04/15, 13:10

  7. Anja Leichsenring uploaded patch set 4 05/04/15, 13:10

  8. Andreas Kienast voted on patch set 4 CR +1 V +1 05/04/15, 13:11

  9. Markus Klein voted on patch set 4 CR +1 V +1 05/04/15, 13:11

  10. Anja Leichsenring voted on patch set 4 CR +1 V +1 05/04/15, 13:11

  11. Stephan Großberndt voted on patch set 4 CR +1 05/04/15, 13:12

  12. Stephan Großberndt voted on patch set 4 V +1 05/04/15, 13:12

  13. Helmut Hummel commented on patch set 4 05/04/15, 13:38

    I don't care if this is merged. Fine with that. I only want to be sure that everybody knows that this will not significantly increase the security of a TYPO3 installation. With all folders being accessible in document root, it will *always* be possible to find out the branch of the installation with close to 0 effort
  14. Wouter Wolters updated the commit message in patch set 5 05/05/15, 10:30

  15. Wouter Wolters commented on patch set 5 CR -2 05/05/15, 10:31

    Discussion about this will take place in June!
  16. Robert Sink commented on patch set 5 06/06/15, 06:44

    I am curious. I've been noticing web apps removing version information from meta & footer citing minor security concern(s). Since I like to play devil's advocate, I'm wondering if there is a part-time system admin [such as myself] that these apps [that have gone such route] make it harder for me to ferret out the version number. Isn't it more likely that I wouldn't update and fall into possible security concerns bc I was running an older version unawares? Honestly, I want to know the security implications both ways. I've gone in and re-added versioning to my footers just so I can run a check [via curl] and check it against upstrean versions [via jsoncpp]. Not bc I'm a hacker, but bc I want to keep my software updated. The things we do in the name of security can cut both ways; so, someone please tell me [besides targeted attacks] how keeping up to date [in my user/part-time admin case] is not more security conscious.
  17. Markus Klein commented on patch set 5 06/06/15, 09:36

    @Robert: The exact version number is still displayed in the title if you're logged into BE.
  18. Wouter Wolters uploaded patch set 6 06/15/15, 09:10

  19. Wouter Wolters voted on patch set 6 CR 0 06/15/15, 09:13

  20. Helmut Hummel voted on patch set 6 CR +2 V +2 06/15/15, 09:44

  21. Andreas Kienast voted on patch set 6 CR +1 V +1 06/15/15, 09:49

  22. Helmut Hummel merged patch set 6 06/15/15, 09:54

  23. Helmut Hummel commented on patch set 7 06/15/15, 09:54

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit c68403276d8963b3ac623e1e03e9874d9afd121c