37957[TASK] Initialize caches via GeneralUtility::makeInstance() and split code
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 6
- typo3/sysext/core/Classes/Cache/Backend/Typo3DatabaseBackend.php+10 −62
- typo3/sysext/core/Classes/Cache/CacheFactory.php4+4 −6
- typo3/sysext/core/Tests/Unit/Cache/Backend/Typo3DatabaseBackendTest.php+12 −76
- typo3/sysext/dbal/Classes/Cache/Backend/Typo3DatabaseBackend.php2new+69 −0
- typo3/sysext/dbal/Tests/Unit/Cache/Backend/Typo3DatabaseBackendTest.php2new+567 −0
- typo3/sysext/dbal/ext_localconf.php+1 −0
Review log 19
-
Andreas Kienast uploaded patch set 1 03/19/15, 16:40
-
Wouter Wolters commented on patch set 1 V -1 03/19/15, 17:50
https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/55053324 -
Wouter Wolters commented on patch set 1 03/19/15, 17:51
CacheFactory.php:76leading slashes with makeInstance is wrongTypo3DatabaseBackend.php:17missing class comment -
Andreas Kienast uploaded patch set 2 03/19/15, 18:57
-
Andreas Kienast commented on patch set 2 V -1 03/19/15, 18:57
Unit tests are failing, needs investigation -
Nicole Hummel uploaded patch set 3 03/19/15, 20:09
-
Nicole Hummel commented on patch set 3 CR +1 V +1 03/19/15, 20:10
Adjusted unit tests and moved the old tests to dbal extension. -
Jigal van Hemert commented on patch set 3 CR -1 03/20/15, 10:21
Christian must really have a look at the makeInstance() part and see if it is possible at all to use it here. The comments in the source code explain that it was used on purpose.Two quite different topics. Maybe split the patch in two issue.CacheFactory.php:76The comment above explains why the new operator is used.CacheFactory.php:85See above -
Christian Kuhn commented on patch set 3 CR -1 03/24/15, 21:45
No offense Andy, but this may be critical in early bootstrap and/or install tool. I'm not sure about that and will need some time to have a deeper look. -1 for now until it is confirmed that is harmless ... -
Markus Klein commented on patch set 3 03/24/15, 22:12
@lolli: I guess we can only know this by trying. Since Nicole gave v+1 already I guess does work. I suspect that it works with Core-Cache-Backends only due to being loaded by composer class loader now. -
Markus Klein commented on patch set 3 04/09/15, 23:32
CacheFactory.php:75Remove the comment as it does not apply anymore. -
Andreas Kienast uploaded patch set 4 04/10/15, 05:59
-
Markus Klein commented on patch set 4 04/10/15, 09:46
@lolli, a final ok please -
Christian Kuhn commented on patch set 4 04/10/15, 10:53
i can not sign this off without having a closer look. on testing, please take care of the following: * initial install still works * installing distribution works * install tool comes up, the preset changes work and the 'broken ext test' works. * backend and frontend works * extensionsmanager successfully d/l and installs extensions that have dependencies -
Christian Kuhn commented on patch set 4 04/10/15, 10:56
on reading, please have a detailed look at the dependencies of makeInstance and if the singleton pattern might be broken early. on testing, please make sure that the dbal xclass is actually active and in action if dbal is activated. Other than that: i basically like the change and the dbal code extraction from the t3-db-backend is fine and makes this relatively complicated backend better readable. Please just make sure this patch is bullet proof. -
Christian Kuhn commented on patch set 4 04/10/15, 10:59
btw: there is other code in the install tool than creates for example the cacheManager with new, if i remember correctly. This was done to circumvent the SnigletonInterface for the install tool (it needs a second instance) This also needs a look if it interferes with this change. -
Markus Klein commented on patch set 4 07/04/15, 01:37
Typo3DatabaseBackend.php:31getterTypo3DatabaseBackendTest.php:11indentation wrongTypo3DatabaseBackendTest.php:51shorten 'em -
Oliver Hader uploaded patch set 5 10/09/15, 06:45
-
Andreas Kienast abandoned the change 12/09/15, 20:14
Too intrusive and error-prone. Abandoned for the time being