37971[BUGFIX] Fallback to version of ext_emconf.php if not found in Composer
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Fabien Udriot +1
- Adrien Crivelli +1
- Nicole Hummel +1
-
Verified V +2
- Xavier Perseguers +2
- Adrien Crivelli +1
- Nicole Hummel +1
Issues 1
Files 1
Review log 28
Show 3 earlier messages
-
Peter Niederlag uploaded patch set 1 03/20/15, 12:40
-
Fabien Udriot commented on patch set 1 04/02/15, 15:19
According to the feedback of Mathias Brodala it looks the Extension Manager is not complaining any more if the version number is missing in the Composer manifest. Just reporting here... Reference: https://github.com/fabarea/media/pull/12 -
Peter Niederlag commented on patch set 1 04/02/15, 15:41
There are definitly certain conditions in 6.2.x where installation failed with composer.json without a version. Helmut confirmed this as well, maybe he can fill the missing details/circumstances in the bug report
-
Adrien Crivelli voted on patch set 1 CR +1 V +1 04/03/15, 10:37
-
Fabien Udriot uploaded patch set 2 04/07/15, 13:20
-
Fabien Udriot commented on patch set 2 V +1 CR +1 04/07/15, 13:22
Package.php:207Version could have different type of value: empty string or NULL. Therefore, adding a protected method in patch set 2 -
Fabien Udriot commented on patch set 2 04/07/15, 13:22
Is this patch not application to master? -
Adrien Crivelli voted on patch set 2 CR +1 V +1 04/08/15, 12:37
-
Markus Klein commented on patch set 2 04/09/15, 23:03
Package.php:336datatype missing -
Helmut Hummel commented on patch set 2 CR -1 04/10/15, 09:24
Master patch should be merged first btw. Rather than hacking our way to get the extension version from a different place if not found in composer.json, what about really lifting the requirement of the version to be mandatory. AFAIK the version is not evaluated by the package management at all currently (only EM uses it and EM still uses ext_emconf.php). -
Nicole Hummel commented on patch set 2 CR -2 05/01/15, 12:34
Cannot reproduce and version is already taken from ext_emconf.php (typo3/sysext/core/Classes/Package/Package.php:162) -
Nicole Hummel commented on patch set 2 07/13/15, 15:52
See the patch in master now https://review.typo3.org/#/c/41133/ -
Nicole Hummel abandoned the change 07/13/15, 19:39
This patch is for current master only, so I abandon this patch for 6.2 -
Xavier Perseguers restored the change 01/11/16, 10:38
This fixes a bug where dependency to "future-ready" extensions cause TYPO3 6.2 to crash when activating an extension with such dependency -
Xavier Perseguers uploaded patch set 3 01/11/16, 10:38
-
Xavier Perseguers commented on patch set 3 CR +1 V +1 01/11/16, 10:39
This is a hack, ok, but it works and is only target at 6.2. I see this as an important fix to prevent us asking developers who care for backward compatibility to introduce warnings in their composer.json just because they care to maintain compatibility with an older LTS with active support. -
Nicole Hummel commented on patch set 3 01/11/16, 10:48
IMHO you have to add a new ticket for your issue to be able to review the case and patch -
Xavier Perseguers commented on patch set 3 01/11/16, 11:01
Nicole: this is the problem I'm facing: https://forge.typo3.org/issues/72631 -
Helmut Hummel commented on patch set 3 01/11/16, 11:18
Meanwhile I would be fine to include this patch. -
Adrien Crivelli voted on patch set 3 CR +1 V +1 01/11/16, 16:09
-
Frank Nägler voted on patch set 3 CR +1 01/18/16, 08:51
-
Xavier Perseguers commented on patch set 3 01/19/16, 06:44
ping :) -
Nicole Hummel uploaded patch set 4 01/19/16, 09:26
-
Nicole Hummel commented on patch set 4 CR +1 V +1 01/19/16, 09:27
I still would prefer to remove the (broken) composer handling for 6.2 (see https://review.typo3.org/#/c/46031/) but as workaround I'm fine with the patch -
Adrien Crivelli voted on patch set 4 CR +1 V +1 01/19/16, 09:36
-
Fabien Udriot voted on patch set 4 CR +1 01/19/16, 16:00
-
Xavier Perseguers commented on patch set 4 CR +2 V +2 02/09/16, 08:33
Since other patch to fully remove composer is still in WIP and this one is ready, I merge it as discussed. -
Gerrit merged patch set 4 02/09/16, 08:33