Review main Merged

37981[BUGFIX] Open modal over complete backend and cleanup

Frank Nägler CR +2 V +2 Easy +3 −2 updated 03/22/15, 16:18

Commit message

Open modal over complete backend window and not only on
current frame. And cleanup the old HTML on dismiss by register
the event 'modal-dismiss'.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Frans Saris +1
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Frans Saris +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 8

  1. Frank Nägler uploaded patch set 1 03/20/15, 21:41

  2. Frans Saris voted on patch set 1 CR +1 03/21/15, 08:48

  3. Frans Saris commented on patch set 1 03/21/15, 09:06

    Where in the be can a modal be triggered? To test this
  4. Andreas Kienast commented on patch set 1 03/21/15, 22:16

    > Where in the be can a modal be triggered? List module > Delete Record (for example ;))
  5. Frans Saris voted on patch set 1 V +1 03/22/15, 15:45

  6. Andreas Kienast voted on patch set 1 CR +1 V +1 03/22/15, 15:47

  7. Wouter Wolters voted on patch set 1 V +2 CR +2 03/22/15, 16:18

  8. Wouter Wolters merged patch set 1 03/22/15, 16:18