Review main Merged

37995[TASK] Remove unneeded function call in TYPO3 Bootstrap

Benni Mack CR +2 V +2 Easy +1 −15 updated 03/22/15, 16:38

Commit message

The method "loadAdditionalConfigurationFromExtensions()"
inside the TYPO3 Bootstrap is just used as a wrapper
now for calling the extLocalconf method itself,
and only used within the Bootstrap class within the boostrap->loadTypo3LoadedExtAndExtLocalconf() method.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Jan Helke +1
    • Jigal van Hemert +1
  • Verified V +2
    • Wouter Wolters +2
    • Jan Helke +1
    • Jigal van Hemert +1

Issues 1

Files 1

Review log 18

  1. Benni Mack uploaded patch set 1 03/22/15, 12:44

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 03/22/15, 12:55

  3. Wouter Wolters voted on patch set 1 CR +1 03/22/15, 13:10

  4. Jigal van Hemert commented on patch set 1 CR -1 V -1 03/22/15, 14:34

    I found usages in: - \TYPO3\CMS\Core\Tests\FunctionalTestCaseBootstrapUtility::setUpBasicTypo3Bootstrap() - \TYPO3\CMS\Install\Controller\Action\AbstractAction::loadExtLocalconfDatabaseAndExtTables() - \TYPO3\CMS\Install\Service\ClearCacheService::clearAll() Those also need to be replaced before removing the function. One test case: Use the "Clear All Cache" button in the Install Tool and you'll be greeted with the error message: Detected Fatal Error Call to undefined method TYPO3\CMS\Core\Core\Bootstrap::loadTypo3LoadedExtAndExtLocalconf() in D:\TYPO3\TYPO3_master\typo3\sysext\install\Classes\Service\ClearCacheService.php on line 75
  5. Jigal van Hemert commented on patch set 1 03/22/15, 14:38

    Also, loadAdditionalConfigurationFromExtensions() is protected and can't be used from the other three locations. Make loadAdditionalConfigurationFromExtensions() public or keep the wrapper?
  6. Jan Helke voted on patch set 1 V -1 CR -1 03/22/15, 15:06

  7. Jan Helke commented on patch set 1 03/22/15, 15:10

    How about removing loadAdditionalConfigurationFromExtensions() also and replace every occurace of loadTypo3LoadedExtAndExtLocalconf() with Utility\ExtensionManagementUtility::loadExtLocalconf()?
  8. Benni Mack commented on patch set 1 03/22/15, 15:54

    Jigal, it is a non-public API, and is not meant to be called outside of the bootstrap process.
  9. Jigal van Hemert uploaded patch set 2 03/22/15, 16:09

  10. Jigal van Hemert commented on patch set 2 CR +1 V +1 03/22/15, 16:12

    Made replacement public and used it in functional tests and install tool.
  11. Jigal van Hemert uploaded patch set 3 03/22/15, 16:21

  12. Jigal van Hemert updated the commit message in patch set 4 03/22/15, 16:24

  13. Jigal van Hemert commented on patch set 4 CR +1 V +1 03/22/15, 16:26

    Quickly discussed with Benni. Removed the wrapped function instead and everything is working again.
  14. Jan Helke voted on patch set 4 CR +1 03/22/15, 16:29

  15. Jan Helke voted on patch set 4 V +1 03/22/15, 16:33

  16. Wouter Wolters voted on patch set 4 V +1 CR +1 03/22/15, 16:37

  17. Wouter Wolters voted on patch set 4 V +2 CR +2 03/22/15, 16:38

  18. Wouter Wolters merged patch set 4 03/22/15, 16:38