Review main Merged

38003[TASK][FOLLOWUP] Optimize loading of locallang strings in JavaScript

Andreas Kienast CR +2 V +2 Easy +4 −4 updated 03/22/15, 22:01

Commit message

Rename the method and check if TYPO3_MODE is FE before converting the strings
to UTF-8.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Michael Oehlhof +1
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1

Issues 1

Files 1

Review log 5

  1. Andreas Kienast uploaded patch set 1 03/22/15, 17:07

  2. Michael Oehlhof voted on patch set 1 CR +1 03/22/15, 20:25

  3. Benni Mack voted on patch set 1 CR +1 V +1 03/22/15, 21:12

  4. Wouter Wolters voted on patch set 1 V +2 CR +2 03/22/15, 22:01

  5. Wouter Wolters merged patch set 1 03/22/15, 22:01