Review main Merged

38009[TASK] Set imagecols by default in PHP, not UserTSconfig

Benni Mack CR +2 V +2 Easy +1 −2 updated 03/22/15, 22:16

Commit message

EXT:frontend defines "imagecols" with the default value "1"
but overrides it for TCAdefaults via UserTSconfig to "2".
This can be simplified by doing this directly in PHP.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Jan Helke +1
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Jan Helke +1
    • Andreas Kienast +1

Issues 1

Files 2

Review log 8

  1. Benni Mack uploaded patch set 1 03/22/15, 20:47

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 03/22/15, 21:10

  3. Benni Mack updated the commit message in patch set 2 03/22/15, 21:11

  4. Andreas Kienast voted on patch set 2 CR +1 V +1 03/22/15, 21:12

  5. Wouter Wolters voted on patch set 2 CR +1 03/22/15, 22:07

  6. Jan Helke voted on patch set 2 CR +1 V +1 03/22/15, 22:14

  7. Wouter Wolters voted on patch set 2 V +2 CR +2 03/22/15, 22:16

  8. Wouter Wolters merged patch set 2 03/22/15, 22:16