Review main Merged

38018[FEATURE] Add preProcessStorage signal to ResourceFactory

Frank Nägler CR +2 V +2 Easy +41 −0 updated 02/12/16, 17:48

Commit message

This patch introduces a new signal before a resource storage is initialized.
This is very useful to overwrite the storage configuration before the
storage is created.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1

Issues 1

Files 3

Review log 16

  1. Frank Nägler uploaded patch set 1 03/22/15, 23:55

  2. Frank Nägler commented on patch set 1 V -1 03/22/15, 23:55

    POC not final
  3. TYPO3 Bot commented on patch set 1 06/14/15, 18:21

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/143 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/55422870 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/66770672
  4. TYPO3 Bot commented on patch set 1 06/19/15, 21:13

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/148 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/55422870 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/67585306
  5. Oliver Hader uploaded patch set 2 10/09/15, 06:48

  6. Frank Nägler uploaded patch set 3 01/23/16, 22:09

  7. Frank Nägler updated the commit message in patch set 4 01/23/16, 22:19

  8. Frank Nägler wrote 01/25/16, 09:14

    Patch set 5: Commit message was updated.
  9. Frank Nägler uploaded patch set 6 01/25/16, 09:19

  10. Claus Due commented on patch set 6 CR +1 01/31/16, 13:41

    Love it! Would be perfect for in-development community extension cms_fal which could then initialize itself instead of requiring a CLI task.
  11. Claus Due commented on patch set 6 01/31/16, 15:08

    Name of community extension is "cmis_fal", not "cms_fal". It's a FAL driver for CMIS/Alfresco.
  12. Georg Ringer uploaded patch set 7 01/31/16, 20:27

  13. Georg Ringer voted on patch set 7 CR +1 V +1 01/31/16, 20:27

  14. Jan Helke voted on patch set 7 CR +1 02/12/16, 10:01

  15. Christian Kuhn voted on patch set 7 CR +2 V +2 02/12/16, 17:47

  16. Gerrit merged patch set 7 02/12/16, 17:48