Review main Abandoned

38025[FEATURE] add displayCond CONTAINS/!CONTAINS/CONTAINS_OR operator

Andreas Allacher CR 0 V 0 Normal +88 −0 updated 10/10/15, 08:52

Commit message

A new functionality is introduced that allows displayCond to check if a field contains all values, no value
or at least one value of an UID list.
Useful to check if a record has or has not certain MM relations.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 3

Review log 8

  1. Andreas Allacher uploaded patch set 1 03/23/15, 09:00

  2. Benni Mack commented on patch set 1 06/29/15, 20:13

    Hey Andreas. Nice one. Shouldn't we just extend "IN" with ! and "OR" and allow multiple values?
  3. Andreas Allacher commented on patch set 1 06/29/15, 20:29

    I am open to discussion there. I needed it once and this is the first "solution" there. I used contains because in extbase there is also a differntiation between contains and in operator. But true we could combine it be adding !IN and an optional OR, e.g. IN => [ OR => 'list' ] But one issue might be if I want to search for '5,2,3" as string in an list of values. That would not work with contains currently. Maybe instead of intExplode, it should just use trimExplode - I think then this would work too. Except if I want to search for the string "5,2,3" in that order without any values in between. That might be accepted because 5 and 2 and 3 are in the list. But I don't see any reason to have displayCond like this?
  4. Andreas Allacher commented on patch set 1 06/29/15, 20:30

    Or instead of IN => [ OR => ... ] it could also be like with contains with IN_OR
  5. Benni Mack voted on patch set 1 CR +1 08/12/15, 19:19

  6. Daniel Goerz commented on patch set 1 08/23/15, 11:54

    Could you provide a little testextension to verify the functionality? That would be great.

    Feature-65920-DisplayCondAddContainsOperator.rst:24

    CONTAINS
  7. Andreas Allacher commented on patch set 1 08/23/15, 19:51

    Will try to create one but I cannot promise when because I am currently working on some other private things too. Once I am finished with those, definitely but...
  8. Andreas Allacher abandoned the change 10/10/15, 08:52

    I am abandoning this patch because it is partly fixed and most importantly if one needs more complicated displayCond it is now easier to just use the now FormDataProvider options