Review main Merged

38032[FEATURE] Replace usage of getFuncMenu with TWBS styled substitution

Jan Helke CR +2 V +2 Normal +73 −18 updated 07/09/15, 21:18

Commit message

This patch substitutes the inline usage of BackendUtility::getFuncMenu
with a Bootstrap styled variant.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Christian Kuhn +1

Issues 1

Files 8

Review log 34

Show 9 earlier messages
  1. Jan Helke uploaded patch set 1 03/23/15, 10:54

  2. Wouter Wolters updated the commit message in patch set 2 03/23/15, 11:43

  3. Benni Mack voted on patch set 2 CR +1 V +1 03/23/15, 12:32

  4. Jan Helke uploaded patch set 3 03/23/15, 14:46

  5. Jan Helke uploaded patch set 4 03/23/15, 15:10

  6. Jan Helke uploaded patch set 5 03/23/15, 15:15

  7. Jan Helke uploaded patch set 6 03/23/15, 15:31

  8. Jan Helke uploaded patch set 7 03/23/15, 15:58

  9. Jan Helke uploaded patch set 8 03/23/15, 16:33

  1. Helmut Hummel commented on patch set 8 03/23/15, 16:45

    BackendUtility.php:2904

    do we maybe have other options than adding other method to this multi purpose god class?

    BackendUtility.php:2918

    htmlspecialchars($elementName)
  2. Jan Helke commented on patch set 8 03/23/15, 16:56

    BackendUtility.php:2904 Reply

    I don't see any besides of greating another multi purpose god class or implement the function in the seven files where I replaced it.
  3. Jan Helke uploaded patch set 9 03/26/15, 10:11

  4. Wouter Wolters commented on patch set 9 03/26/15, 10:20

    BackendUtility.php:2901

    replace tab to space here
  5. Jan Helke uploaded patch set 10 04/04/15, 09:50

  6. Jan Helke updated the commit message in patch set 11 04/30/15, 20:47

  7. Jan Helke updated the commit message in patch set 12 04/30/15, 20:47

  8. Jan Helke rebased onto patch set 12 06/16/15, 08:12

  9. Frank Nägler commented on patch set 13 06/18/15, 07:13

    some small remarks

    BackendUtility.php:2985

    why we need the extra params for hsc here? we should not set UTF-8 as string here, the default value for the third parameter is ini_get("default_charset"), maybe use this or get it from core settings.

    BackendUtility.php:2987

    !empty($options)

    BackendUtility.php:2994

    please use implode(LF, $options); instead of the line break in code.
  10. Jan Helke uploaded patch set 14 06/21/15, 20:30

  11. Christian Kuhn commented on patch set 14 CR +1 06/25/15, 22:22

    +1 on reading for now. I'm fine with the additional method. Stuff like that can be deprecated later if everything is properly moved to fluid, but since this will take some time, I'd use the shortcut for now and deal with this additional method in our god class ;)
  12. TYPO3 Bot commented on patch set 14 V -1 07/05/15, 17:51

    Github tests: failure Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/174 Service: continuous-integration/travis-ci/push Description: The Travis CI build could not complete due to an error URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/67760750
  13. Anja Leichsenring updated the commit message in patch set 15 07/09/15, 20:45

  14. Anja Leichsenring uploaded patch set 16 07/09/15, 20:51

  15. Anja Leichsenring commented on patch set 16 CR +1 07/09/15, 20:54

  16. Christian Kuhn voted on patch set 16 CR +1 V +1 07/09/15, 20:58

  17. Wouter Wolters commented on patch set 16 CR -1 07/09/15, 21:07

    PageInformationController.php:81

    space before the 1

    TranslationStatusController.php:71

    space after .=
  18. Wouter Wolters uploaded patch set 17 07/09/15, 21:10

  19. Wouter Wolters voted on patch set 17 V +1 CR +1 07/09/15, 21:11

  20. Markus Klein commented on patch set 16 07/09/15, 21:11

    BackendUtility.php:2987

    Mingling?
  21. Wouter Wolters uploaded patch set 18 07/09/15, 21:13

  22. Wouter Wolters voted on patch set 18 V +1 CR +1 07/09/15, 21:13

  23. Christian Kuhn voted on patch set 18 CR +1 V +1 07/09/15, 21:16

  24. Anja Leichsenring voted on patch set 18 CR +2 V +2 07/09/15, 21:18

  25. Anja Leichsenring merged patch set 18 07/09/15, 21:18