Review main Abandoned

38041[BUG] Method getConfigurationValueByPath does not respect AdditionalConfiguration.php

Peter Foerger CR 0 V 0 Normal +41 −19 updated 03/24/15, 14:20

Commit message

getConfigurationValueByPath has to respect settings from AdditionalConfiguration.php, which is crucial e.g for deployments where AdditionalConfiguration.php becomes created stage specific during the build.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 6

  1. Peter Foerger uploaded patch set 1 03/23/15, 14:40

  2. Peter Foerger updated the commit message in patch set 2 03/23/15, 15:03

  3. Mathias Brodala commented on patch set 2 CR -1 03/23/15, 15:32

    Please abandon this change since the current state is intended. See Forge for details.
  4. Viktor Livakivskyi voted on patch set 2 CR +1 03/24/15, 13:49

  5. Markus Klein commented on patch set 2 CR -2 03/24/15, 13:52

    ConfigurationManager is internal API
  6. Christian Kuhn abandoned the change 03/24/15, 14:20

    Thx. But, this is internal api and additionalConfiguration is not handled at this point by intention. patch will be abandoned.