Review main Abandoned

38046[TASK] Write CSS in DebuggerUtility output

Andreas Kienast CR 0 V 0 Easy +4 −3 updated 06/20/15, 23:25

Commit message

The CSS of DebuggerUtility::var_dump() is now written into $output if
$return is TRUE. Disabling this is still possible by using
`$plainText = TRUE`.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 7

  1. Andreas Kienast uploaded patch set 1 03/23/15, 16:08

  2. Andreas Kienast updated the commit message in patch set 2 03/23/15, 16:09

  3. Helmut Hummel voted on patch set 2 CR +2 03/23/15, 16:46

  4. Helmut Hummel commented on patch set 2 CR 0 03/23/15, 16:51

    Hm, have to revoke my +2 here
  5. Helmut Hummel commented on patch set 2 CR -1 03/23/15, 16:58

    With that change the calling code can never be sure if the styles are on the page (e.g. when previously code calls the utility but (for whatever reasons) does not echo the output (which has the css).
  6. Andreas Kienast abandoned the change 05/27/15, 17:51

  7. TYPO3 Bot commented on patch set 2 06/20/15, 23:25