Review main Merged

38088[TASK] Introduce GruntJS

Benjamin Kott CR +2 V +2 Normal +99 −1 updated 03/24/15, 09:39

Commit message

In order to unify build processes in the backend we introduce
GruntJS as taskrunner. It will provide a global config that takes
over the responsibility for all build processes in the future
starting with the less files of the backend skin.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1

Issues 1

Files 4

Review log 14

  1. Benjamin Kott uploaded patch set 1 03/23/15, 23:23

  2. Benni Mack commented on patch set 1 03/23/15, 23:27

    Please use Build/ instead of build/
  3. Wouter Wolters commented on patch set 1 03/23/15, 23:29

    Gruntfile.js

    Spaces missing and no double ** in the GPL header
  4. Frans Saris commented on patch set 1 03/24/15, 07:59

    package.json:8

    Is it possible to make the version less strict? So we do not have to adjust it with every release?
  5. Benjamin Kott commented on patch set 1 03/24/15, 09:10

    Gruntfile.js Reply

    Done

    package.json:8 Reply

    Talked to Benni M. and Frank N. and decided to stick with it for now since the core version is also 7.2.0-dev and will be changed on release.
  6. Benjamin Kott uploaded patch set 2 03/24/15, 09:11

  7. Benjamin Kott uploaded patch set 3 03/24/15, 09:25

  8. Andreas Kienast voted on patch set 3 CR +1 V +1 03/24/15, 09:30

  9. Wouter Wolters commented on patch set 3 CR -1 03/24/15, 09:36

    .gitignore:28

    Build/node_modules/*
  10. Wouter Wolters uploaded patch set 4 03/24/15, 09:37

  11. Wouter Wolters voted on patch set 4 V +1 CR +1 03/24/15, 09:38

  12. Andreas Kienast voted on patch set 4 V +1 CR +1 03/24/15, 09:38

  13. Andreas Kienast voted on patch set 4 CR +2 V +2 03/24/15, 09:39

  14. Andreas Kienast merged patch set 4 03/24/15, 09:39