38135[TASK] Improve styling of page module
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Michael Oehlhof +1
-
Verified V +2
- Markus Klein +2
- Michael Oehlhof +1
Issues 1
Files 7
- typo3/sysext/backend/Classes/View/PageLayoutView.php2+36 −43
- typo3/sysext/backend/Resources/Public/JavaScript/LayoutModule/DragDrop.js4+5 −5
- typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/structure/_module_web_page.lessdeleted+0 −141
- typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/visual/_module_web_page.lessdeleted+0 −212
- typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/_module_web_page.lessnew+206 −0
- typo3/sysext/t3skin/Resources/Private/Styles/t3skin.less+1 −2
- typo3/sysext/t3skin/Resources/Public/Css/visual/t3skin.css+166 −265
Review log 12
-
Benjamin Kott uploaded patch set 1 03/24/15, 22:23
-
Markus Klein commented on patch set 1 03/24/15, 22:42
DragDrop.js:24why no t3js here?DragDrop.js:27this was formerly placed on the table, now it is on a <td> -
Benjamin Kott commented on patch set 1 03/24/15, 22:45
PageLayoutView.php:504Replyone is prefixed with t3js and is only used as javascript selectorDragDrop.js:24Replythis is a css class thats used for styling and not as selectorDragDrop.js:27Replythere is a difference between columns and column -
Benjamin Kott uploaded patch set 2 03/24/15, 22:52
-
Benjamin Kott commented on patch set 2 03/24/15, 22:52
Adjusted some colors -
Benjamin Kott uploaded patch set 3 03/24/15, 23:16
-
Markus Klein commented on patch set 3 CR -1 03/25/15, 00:00
if defLangBinding=1 then the formatting is not ok yet. Thanks for taking care. -
Benjamin Kott uploaded patch set 4 03/25/15, 00:11
-
Markus Klein commented on patch set 4 CR +1 V +1 03/25/15, 00:17
thx, fine now for the time being -
Michael Oehlhof voted on patch set 4 CR +1 V +1 03/25/15, 01:05
-
Markus Klein voted on patch set 4 CR +2 V +2 03/25/15, 01:51
-
Markus Klein merged patch set 4 03/25/15, 01:51
PageLayoutView.php:504