Review main Merged

38135[TASK] Improve styling of page module

Benjamin Kott CR +2 V +2 Expert +414 −668 updated 03/25/15, 01:51

Commit message

- Improve dropzones
- Improve button sizes
- Improve color balance
- Cleanup LESS

Review

  • Code review CR +2
    • Markus Klein +2
    • Michael Oehlhof +1
  • Verified V +2
    • Markus Klein +2
    • Michael Oehlhof +1

Issues 1

Files 7

Review log 12

  1. Benjamin Kott uploaded patch set 1 03/24/15, 22:23

  2. Markus Klein commented on patch set 1 03/24/15, 22:42

    PageLayoutView.php:504

    we have this class now twice, is this intended?

    DragDrop.js:24

    why no t3js here?

    DragDrop.js:27

    this was formerly placed on the table, now it is on a <td>
  3. Benjamin Kott commented on patch set 1 03/24/15, 22:45

    PageLayoutView.php:504 Reply

    one is prefixed with t3js and is only used as javascript selector

    DragDrop.js:24 Reply

    this is a css class thats used for styling and not as selector

    DragDrop.js:27 Reply

    there is a difference between columns and column
  4. Benjamin Kott uploaded patch set 2 03/24/15, 22:52

  5. Benjamin Kott commented on patch set 2 03/24/15, 22:52

    Adjusted some colors
  6. Benjamin Kott uploaded patch set 3 03/24/15, 23:16

  7. Markus Klein commented on patch set 3 CR -1 03/25/15, 00:00

    if defLangBinding=1 then the formatting is not ok yet. Thanks for taking care.
  8. Benjamin Kott uploaded patch set 4 03/25/15, 00:11

  9. Markus Klein commented on patch set 4 CR +1 V +1 03/25/15, 00:17

    thx, fine now for the time being
  10. Michael Oehlhof voted on patch set 4 CR +1 V +1 03/25/15, 01:05

  11. Markus Klein voted on patch set 4 CR +2 V +2 03/25/15, 01:51

  12. Markus Klein merged patch set 4 03/25/15, 01:51