Review main Merged

38144[BUGFIX] Remove driver id from file move message

Michael Oehlhof CR +2 V +2 Easy +22 −11 updated 05/06/15, 19:57

Commit message

The file move message showed identifiers instead of file and folder names.

Review

  • Code review CR +2
    • Frans Saris +2
    • Christian Weiske +1
    • Christian Kuhn +1
    • Cedric Ziel +1
    • Michael Oehlhof +1
  • Verified V +2
    • Frans Saris +2
    • Christian Weiske +1
    • Michael Oehlhof +1

Issues 1

Files 2

Review log 32

Show 7 earlier messages
  1. Michael Oehlhof uploaded patch set 1 03/25/15, 06:17

  2. Michael Oehlhof uploaded patch set 2 03/28/15, 19:30

  3. Cedric Ziel commented on patch set 2 CR -1 03/31/15, 18:46

    Clipboard.php:652

    CGL requires uppercase booleans

    Clipboard.php:659

    same here
  4. Michael Oehlhof commented on patch set 2 03/31/15, 21:36

    Cedric, have you followed the driver discussion beginning at 30.03. 16:50 in the #typo3-cms Slack channel? "This patch only fixes the symptom of a deeper issue"
  5. Cedric Ziel commented on patch set 2 04/01/15, 05:54

    Not really.
  6. Christian Weiske commented on patch set 2 V -1 04/17/15, 14:49

    > Uploaded patch set 2. This does not help. Instead of > Move "12:abcde" into "12:fo-cde"? I get now > Move "abcde" into "fo-cde"? The patch should use the getName() methods of the file, and not modify the identifiers.
  7. Michael Oehlhof uploaded patch set 3 04/19/15, 23:27

  1. Michael Oehlhof uploaded patch set 4 04/20/15, 05:10

  2. Michael Oehlhof updated the commit message in patch set 5 04/20/15, 05:12

  3. Christian Weiske commented on patch set 5 V -1 04/21/15, 11:59

    This makes progress :) The copy message now shows the correct file name, but unfortunately still the folder ID.
  4. Michael Oehlhof commented on patch set 5 04/21/15, 12:25

    On the page we have 3 different positions for the paste buttons. Which button have you used for pasting? In the 3rd, on the list of the folder names, that was the one with the driver id and identifier shown. There I have changed it to show the folder name instead.
  5. Christian Weiske commented on patch set 5 04/21/15, 13:15

  6. Christian Weiske commented on patch set 5 04/21/15, 13:16

    When using the "paste into" menu item in the tree's folder's context menu, I get IDs only.
  7. Christian Weiske commented on patch set 5 04/21/15, 13:18

    > When using the "paste into" menu item in the tree's folder's > context menu, I get IDs only. http://fotos.cweiske.de/screenshots/2015-04-21%20typo3%20paste%20into.png
  8. Michael Oehlhof commented on patch set 5 04/21/15, 13:49

    OK, the popup menu in the folder tree was out of my focus. Have looked at the icons in the right pane.
  9. Michael Oehlhof uploaded patch set 6 04/21/15, 16:35

  10. Christian Weiske commented on patch set 6 V -1 04/23/15, 12:53

    The paste message I get when using the context menu in the folder tree is fully correct now. Unfortunately, the one I get from the paste button in the file list (title: "Paste in clipboard content") still has the folder ID. This *might* be related to https://forge.typo3.org/issues/64759 . It has to do with it. $this->path in FileList is set to $folderObject->getIdentifier(). This has to be fixed with #64759.
  11. Christian Weiske voted on patch set 6 V +1 CR +1 04/23/15, 12:54

  12. Christian Weiske uploaded patch set 7 04/23/15, 13:07

  13. Christian Weiske commented on patch set 6 04/23/15, 13:09

    I can confirm that with the adjustments of #64759 all paste messages are fine now.
  14. Christian Weiske commented on patch set 7 CR +1 V +1 04/23/15, 13:11

    Sorry, no idea why I pushed a patch 7.
  15. Michael Oehlhof voted on patch set 7 CR +1 V +1 04/23/15, 14:48

  16. Michael Oehlhof commented on patch set 7 04/23/15, 14:49

    So I can vote for my own patch again.
  17. Christian Kuhn commented on patch set 7 CR +1 05/06/15, 10:41

    +1 on reading. On testing I can verify this still works with the default driver, but I have no custom driver at hand to test the real bugfix ...
  18. Christian Kuhn uploaded patch set 8 05/06/15, 11:20

  19. Christian Kuhn commented on patch set 8 CR +1 05/06/15, 11:20

    args, pushed by accident. sorry for killing the votes.
  20. Christian Weiske voted on patch set 8 CR +1 V +1 05/06/15, 11:21

  21. Cedric Ziel voted on patch set 8 CR +1 05/06/15, 11:50

  22. Michael Oehlhof commented on patch set 8 05/06/15, 16:55

    @Christian Kuhn: You can test with the driver I have written to test it. https://forge.typo3.org/projects/extension-teamruhr_fal_test/files
  23. Michael Oehlhof voted on patch set 8 CR +1 V +1 05/06/15, 16:57

  24. Frans Saris voted on patch set 8 CR +2 V +2 05/06/15, 19:57

  25. Frans Saris merged patch set 8 05/06/15, 19:57