Review TYPO3_6-2 Abandoned

38245[BUGFIX] PropertyMapper fails mapping an ObjectStorage

Bernhard Kraft CR 0 V 0 Easy +12 −6 updated 04/09/16, 11:03

Commit message

When a controller gets passed an ObjectStorage the property mapper
fails to properly map the contents of the GET/POST array to the
objects contained in the ObjectStorage.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 9

  1. Bernhard Kraft uploaded patch set 1 03/26/15, 14:01

  2. Bernhard Kraft commented on patch set 1 03/26/15, 14:02

    This is an alternative solution to: https://review.typo3.org/#/c/38243/
  3. Markus Klein commented on patch set 1 CR +1 04/09/15, 23:14

    I prefer this solution
  4. TYPO3 Bot commented on patch set 1 V -1 06/20/15, 23:58

  5. Markus Klein commented on patch set 1 V -1 09/09/15, 10:01

    unittests need adjustment
  6. Andreas Wolf commented on patch set 1 CR -1 03/04/16, 11:26

    Argument.php:184

    Uhm… no?

    Argument.php:250

    This is clear from the code, but *why* is it only then necessary?
  7. Benni Mack commented on patch set 1 CR -1 03/06/16, 01:10

    no change since almost a year, please come up with a solution soon, otherwise I'm going to abandon this change because of lack of interest.
  8. Benni Mack abandoned the change 04/08/16, 13:24

    no feedback, no activity, will abandon for now. If there is interest, this can be opened (incl. rebasing) again.
  9. Bernhard Kraft commented on patch set 1 04/09/16, 11:03

    I am completely stuck in a project ongoing since 2 months and I am quite over deadline so I do not have much time for core issues. Sorry.