38272[FEATURE] Configure section for pagination widget
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Stefan Neufeind +1
- Georg Ringer +1
- Markus Sommer +1
- David Greiner +1
-
Verified V +2
- Frank Nägler +2
- Georg Ringer +1
Issues 1
Files 3
Review log 27
Show 2 earlier messages
-
Mathias Schreiber voted on patch set 2 CR +1 V +1 03/27/15, 20:15
-
Anja Leichsenring commented on patch set 2 CR -1 03/27/15, 20:48
would you please provide a rst file, after this is a feature? Great improvement by the way, thank you. Find a rst file generator here: https://forger.typo3.org/standard/rst and examples in typo3/sysext/core/Documentation/Changelog/master -
Bernhard Kraft uploaded patch set 3 03/31/15, 19:32
-
Bernhard Kraft commented on patch set 3 03/31/15, 19:38
Added a .rst file documenting the feature. -
Mathias Schreiber commented on patch set 3 V +1 03/31/15, 20:11
I am reluctant to giving a -1 on review because the headline in the rst under examples has a space in front. I'm on mobile phone right now so can't change it from here, otherwise I'd have done it. -
Georg Ringer uploaded patch set 4 04/02/15, 03:42
-
Georg Ringer voted on patch set 4 V +1 CR +1 07/13/15, 05:31
-
Andreas Kienast commented on patch set 4 CR -1 07/13/15, 07:01
Feature-66070-ConfigureAnchorForPaginationWidget.rst:2Feature: #66070 - -
Georg Ringer uploaded patch set 5 07/14/15, 19:23
-
Stefan Neufeind voted on patch set 5 CR +1 07/15/15, 21:37
-
David Greiner commented on patch set 5 CR -1 07/16/15, 04:55
IMHO the attribute should be named "section" instead of "anchor" like it is known from all the other viewhelpers. -
Stefan Neufeind commented on patch set 5 CR -1 07/16/15, 07:57
Agreed, I checked that it's named "section" in widget.link, not anchor like mentioned in the commit-msg. I will take care. -
Stefan Neufeind uploaded patch set 6 07/16/15, 08:01
-
David Greiner voted on patch set 6 CR +1 07/16/15, 08:04
-
Anja Leichsenring commented on patch set 6 CR -1 07/16/15, 08:05
please adjust the rst file accordingly -
Georg Ringer uploaded patch set 7 07/16/15, 08:18
-
Georg Ringer voted on patch set 7 CR +1 V +1 07/16/15, 08:18
-
David Greiner voted on patch set 7 CR +1 07/16/15, 08:21
-
Bernhard Kraft commented on patch set 7 07/16/15, 09:24
In my opinion "anchor" would be the better term. We already have "section" for defining pieces of html (f:section) and section is a quite more common term than "anchor". So using "anchor" would reduce confusion. And indeed the "<a>" tag stands for anchor. -
Stefan Neufeind commented on patch set 7 CR +1 07/16/15, 12:55
@Bernhard: I get your point. But I guess you agree we with me we should stick to *one* consistent wording? Separately we might discuss changing the wording (including deprecation) if you wish - but we'd need to coordinate that with "upstream" Fluid then as well - separate task. Imho we shouldn't let this review stall just because of the word. -
Frank Nägler commented on patch set 7 07/16/15, 13:44
I will not block this because of the naming stuff, but imo the correct wording would be fragmentIdentifier or common name hash / urlhash. -
Stefan Neufeind commented on patch set 7 07/16/15, 15:56
@Frank: We have "section" as a known term in several places and can't really change it imho. -
Markus Sommer voted on patch set 7 CR +1 07/17/15, 09:40
-
Frank Nägler voted on patch set 7 CR +2 V +2 07/20/15, 15:20
-
Frank Nägler merged patch set 7 07/20/15, 15:20