Review main Merged

38325[TASK] Adjust layout of openid settings in backend

Frank Nägler CR +2 V +2 Easy +20 −15 updated 03/30/15, 10:37

Commit message

The openid logo in user settings was to big and the popup
styling was adjusted.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Markus Klein +1
  • Verified V +2
    • Jigal van Hemert +2
    • Markus Klein +1

Issues 1

Files 7

Review log 10

  1. Frank Nägler uploaded patch set 1 03/28/15, 17:48

  2. Markus Klein commented on patch set 1 03/28/15, 20:17

    after clicking the button in the wizard, I still have a wrong path
  3. Jigal van Hemert commented on patch set 1 CR -1 03/29/15, 15:47

    Works in my installation, just a few remarks for the styling.
    to -> too.

    OpenidModuleSetup.php:62

    200 is not high enough for the login with many OpenID providers.

    Content.html:46

    Hardcoded text.
  4. Frank Nägler commented on patch set 1 CR -1 03/29/15, 15:55

    will come up with a new patchset
  5. Markus Klein uploaded patch set 2 03/29/15, 21:16

  6. Markus Klein commented on patch set 2 CR -1 03/29/15, 21:17

    path in wizard still broken (abs path)
  7. Markus Klein uploaded patch set 3 03/29/15, 21:21

  8. Markus Klein voted on patch set 3 CR +1 V +1 03/29/15, 21:21

  9. Jigal van Hemert voted on patch set 3 CR +2 V +2 03/30/15, 10:37

  10. Jigal van Hemert merged patch set 3 03/30/15, 10:37