38325[TASK] Adjust layout of openid settings in backend
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Markus Klein +1
-
Verified V +2
- Jigal van Hemert +2
- Markus Klein +1
Issues 1
Files 7
- typo3/sysext/openid/Classes/OpenidModuleSetup.php1+2 −2
- typo3/sysext/openid/Classes/Wizard.php+1 −3
- typo3/sysext/openid/Configuration/TCA/Overrides/be_users.php+2 −2
- typo3/sysext/openid/Resources/Private/Language/Wizard.xlf+3 −0
- typo3/sysext/openid/Resources/Private/Templates/Wizard/Content.html1+9 −3
- typo3/sysext/openid/Resources/Public/StyleSheets/Wizard.css+3 −5
- typo3/sysext/openid/ext_icon_small.pngnewbinary
Review log 10
-
Frank Nägler uploaded patch set 1 03/28/15, 17:48
-
Markus Klein commented on patch set 1 03/28/15, 20:17
after clicking the button in the wizard, I still have a wrong path -
Jigal van Hemert commented on patch set 1 CR -1 03/29/15, 15:47
Works in my installation, just a few remarks for the styling.to -> too.OpenidModuleSetup.php:62200 is not high enough for the login with many OpenID providers.Content.html:46Hardcoded text. -
Frank Nägler commented on patch set 1 CR -1 03/29/15, 15:55
will come up with a new patchset -
Markus Klein uploaded patch set 2 03/29/15, 21:16
-
Markus Klein commented on patch set 2 CR -1 03/29/15, 21:17
path in wizard still broken (abs path) -
Markus Klein uploaded patch set 3 03/29/15, 21:21
-
Markus Klein voted on patch set 3 CR +1 V +1 03/29/15, 21:21
-
Jigal van Hemert voted on patch set 3 CR +2 V +2 03/30/15, 10:37
-
Jigal van Hemert merged patch set 3 03/30/15, 10:37