Review main Merged

38327[BUGFIX] System>Configuration: Fix search in

Michael Oehlhof CR +2 V +2 Easy +3 −4 updated 03/30/15, 12:47

Commit message

Only search in data which are scalars.

Review

  • Code review CR +2
    • Markus Klein +2
    • Andreas Kienast +1
  • Verified V +2
    • Markus Klein +2
    • Andreas Kienast +1

Issues 1

Files 2

Review log 21

  1. Michael Oehlhof uploaded patch set 1 03/29/15, 00:46

  2. Markus Klein commented on patch set 1 03/29/15, 11:48

    This describes the bug and not the fix. Please change the message to describe what is fixed
  3. Markus Klein commented on patch set 1 03/29/15, 11:48

    ArrayBrowser.php:198

    searchString needs to be preg_quote()'ed
  4. Michael Oehlhof uploaded patch set 2 03/29/15, 11:54

  5. Markus Klein commented on patch set 2 03/29/15, 18:45

    http://wiki.typo3.org/CommitMessage_Format_%28Git%29 Present tense. And please describe what we change. This says nothing about the change but is more the content of the forge ticket. (which would lack any information what the error actually is)

    ArrayBrowser.php:198

    This does not change within the function. put it on top once.
  6. Markus Klein commented on patch set 2 CR -1 03/29/15, 18:45

    will push an update
  7. Markus Klein uploaded patch set 3 03/29/15, 18:57

  8. Markus Klein commented on patch set 3 CR -1 03/29/15, 19:02

    ArrayBrowser.php:192

    hm.. preg_quote also kills operators like ".". Investigating
  9. Markus Klein uploaded patch set 4 03/29/15, 19:04

  10. Markus Klein voted on patch set 4 CR +1 V +1 03/29/15, 19:05

  11. Markus Klein uploaded patch set 5 03/29/15, 19:05

  12. Markus Klein voted on patch set 5 CR +1 V +1 03/29/15, 19:06

  13. Michael Oehlhof voted on patch set 5 CR +1 V +1 03/29/15, 22:45

  14. Andreas Kienast uploaded patch set 6 03/30/15, 07:11

  15. Andreas Kienast voted on patch set 6 CR +1 V +1 03/30/15, 07:12

  16. Michael Oehlhof voted on patch set 6 CR +1 V +1 03/30/15, 10:55

  17. Markus Klein commented on patch set 6 V -1 CR -1 03/30/15, 12:14

    ArrayBrowser.php:197

    no please don't! you will not be able to search for things with slash!
  18. Andreas Kienast uploaded patch set 7 03/30/15, 12:25

  19. Andreas Kienast commented on patch set 7 CR +1 V +1 03/30/15, 12:26

    Reverted my last change to unbreak wanted behaviour. I'll think of a proper solution to auto-escape slashes.
  20. Markus Klein voted on patch set 7 CR +2 V +2 03/30/15, 12:31

  21. Markus Klein merged patch set 7 03/30/15, 12:47