Review main Merged

38335[TASK] Trigger events on buttons in Modal.js

Frank Nägler CR +2 V +2 Normal +96 −37 updated 03/31/15, 09:05

Commit message

Modal.js triggers now events which can be binded.
This patch change some implementations in the core which now use
the new events.
For a better performance, the modal template has changed to a simple
text concatination.

Review

  • Code review CR +2
    • Markus Klein +2
    • Andreas Kienast +1
  • Verified V +2
    • Markus Klein +2
    • Andreas Kienast +1

Issues 1

Files 3

Review log 15

  1. Frank Nägler uploaded patch set 1 03/29/15, 13:50

  2. Markus Klein updated the commit message in patch set 2 03/29/15, 14:39

  3. Markus Klein commented on patch set 2 03/29/15, 15:34

    Modal.js:28

    why that?

    Modal.js:99

    is that always a "danger"? Sometimes the OK option is positive
  4. Frank Nägler uploaded patch set 3 03/29/15, 17:37

  5. Frank Nägler commented on patch set 3 CR -1 03/29/15, 18:07

    on it
  6. Frank Nägler uploaded patch set 4 03/29/15, 18:13

  7. Frank Nägler commented on patch set 2 03/29/15, 18:13

    Modal.js:28 Reply

    Done

    Modal.js:99 Reply

    Done
  8. Markus Klein voted on patch set 4 CR +1 03/29/15, 19:15

  9. Daniel Sattler voted on patch set 4 CR +1 V +1 03/30/15, 19:29

  10. Markus Klein uploaded patch set 5 03/30/15, 22:57

  11. Markus Klein voted on patch set 5 CR +1 V +1 03/30/15, 23:01

  12. Andreas Kienast uploaded patch set 6 03/31/15, 06:01

  13. Andreas Kienast voted on patch set 6 CR +1 V +1 03/31/15, 06:01

  14. Markus Klein voted on patch set 6 CR +2 V +2 03/31/15, 09:05

  15. Markus Klein merged patch set 6 03/31/15, 09:05