Review main Merged

38358[TASK] Load Placeholder.js via bower

Wouter Wolters CR +2 V +2 Easy +31 −8 updated 03/31/15, 08:56

Commit message

The Placeholder.js library previously located in "typo3/contrib/placeholdersjs" is now
fetched via bower and copied to the public JavaScript folder via Grunt.

Review

  • Code review CR +2
    • Markus Klein +2
    • Daniel Sattler +1
  • Verified V +2
    • Markus Klein +2
    • Daniel Sattler +1

Issues 1

Files 6

Review log 7

  1. Wouter Wolters uploaded patch set 1 03/30/15, 16:44

  2. Daniel Sattler voted on patch set 1 CR +1 V +1 03/30/15, 19:07

  3. Andreas Kienast commented on patch set 1 03/31/15, 06:17

    Maybe a dumb question: Is it save to use this library as it is licensed under MIT?
  4. Markus Klein commented on patch set 1 03/31/15, 08:52

    cite from wiki: Many of the most common free software licenses, such as the original MIT/X license, ... are "GPL-compatible". That is, their code can be combined with a program under the GPL without conflict
  5. Markus Klein commented on patch set 1 03/31/15, 08:55

    By the way I can really recommend https://www.gnu.org/philosophy/license-list.html I learned a lot there.
  6. Markus Klein voted on patch set 1 CR +2 V +2 03/31/15, 08:56

  7. Markus Klein merged patch set 1 03/31/15, 08:56