38358[TASK] Load Placeholder.js via bower
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Daniel Sattler +1
-
Verified V +2
- Markus Klein +2
- Daniel Sattler +1
Issues 1
Files 6
- Build/bower.json+2 −1
- Build/Gruntfile.js+2 −0
- typo3/contrib/placeholdersjs/placeholders.jquery.min.jsdeleted+0 −5
- typo3/sysext/backend/Classes/Controller/LoginController.php+1 −1
- typo3/sysext/backend/Classes/Form/FormEngine.php+1 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/placeholders.jquery.min.jsnew+25 −0
Review log 7
-
Wouter Wolters uploaded patch set 1 03/30/15, 16:44
-
Daniel Sattler voted on patch set 1 CR +1 V +1 03/30/15, 19:07
-
Andreas Kienast commented on patch set 1 03/31/15, 06:17
Maybe a dumb question: Is it save to use this library as it is licensed under MIT? -
Markus Klein commented on patch set 1 03/31/15, 08:52
cite from wiki: Many of the most common free software licenses, such as the original MIT/X license, ... are "GPL-compatible". That is, their code can be combined with a program under the GPL without conflict -
Markus Klein commented on patch set 1 03/31/15, 08:55
By the way I can really recommend https://www.gnu.org/philosophy/license-list.html I learned a lot there. -
Markus Klein voted on patch set 1 CR +2 V +2 03/31/15, 08:56
-
Markus Klein merged patch set 1 03/31/15, 08:56