Review main Merged

38360[TASK] Move jquery.clearable.js to ext:backend

Wouter Wolters CR +2 V +2 Easy +17 −9 updated 05/05/15, 09:37

Commit message

This also makes jquery.clearable a solid standalone
AMD module.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1

Issues 1

Files 8

Review log 13

  1. Wouter Wolters uploaded patch set 1 03/30/15, 19:04

  2. Michael Oehlhof uploaded patch set 2 04/24/15, 18:08

  3. Michael Oehlhof commented on patch set 2 04/24/15, 19:54

    Rebased to solve the merge conflict.
  4. Christian Kuhn commented on patch set 2 V -1 04/30/15, 10:10

    BE login fails if patch is applied.
  5. Wouter Wolters commented on patch set 2 CR -2 04/30/15, 10:39

    This is a wrong approach. Benni told me one of his colleagues will take over this one to rewrite the plugin.
  6. Benni Mack uploaded patch set 3 05/05/15, 09:19

  7. Wouter Wolters voted on patch set 3 CR 0 05/05/15, 09:25

  8. Andreas Kienast voted on patch set 3 CR +1 V +1 05/05/15, 09:28

  9. Wouter Wolters commented on patch set 3 V -1 05/05/15, 09:29

    Login.js fails
  10. Wouter Wolters uploaded patch set 4 05/05/15, 09:30

  11. Wouter Wolters voted on patch set 4 V +1 CR +1 05/05/15, 09:32

  12. Andreas Kienast voted on patch set 4 CR +2 V +2 05/05/15, 09:37

  13. Andreas Kienast merged patch set 4 05/05/15, 09:37