Review main Merged

38367[FEATURE] Allow page title edit by double-click

Andreas Kienast CR +2 V +2 Normal +188 −5 updated 05/01/15, 16:30

Commit message

If a user has proper permissions, the page title can
be edited in "Page" and "List" module by double-clicking on the header.
The header will transform into a form which sends an ajax request
after saving.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Nicole Hummel +1
  • Verified V +2
    • Anja Leichsenring +2
    • Nicole Hummel +1

Issues 1

Files 4

Review log 22

  1. Andreas Kienast uploaded patch set 1 03/31/15, 08:40

  2. Andreas Kienast uploaded patch set 2 03/31/15, 08:42

  3. Xavier Perseguers commented on patch set 1 V +1 03/31/15, 08:43

    Nice addition, what about having that for translated pages as well? What do you think?
  4. Xavier Perseguers commented on patch set 2 V -1 03/31/15, 08:48

    OK, let's forget about the translated label, it works nearly if you just select the other language as "main" language. But I'd like to see the translated title updated as well ^^: 1) Open a page 2) Create a translation 3) Switch to mode "language" => you see two/... columns (default + other language-s) 4) Change the main language with the second dropdown on top 5) Update the title => the translated title is not automatically updated in the second column
  5. Andreas Kienast uploaded patch set 3 03/31/15, 09:19

  6. Andreas Kienast uploaded patch set 4 04/01/15, 18:49

  7. Andreas Kienast uploaded patch set 5 04/13/15, 16:20

  8. Andreas Kienast commented on patch set 5 04/13/15, 16:20

    Ready to test :)
  9. Andreas Kienast uploaded patch set 6 04/13/15, 16:23

  10. Felix Kopp commented on patch set 6 04/13/15, 20:33

    PageActions.js:47

    Please buttons on the right :)
  11. Andreas Kienast uploaded patch set 7 04/14/15, 17:22

  12. Nicole Hummel commented on patch set 7 CR -1 V -1 04/30/15, 10:46

    Will push an update
  13. Nicole Hummel uploaded patch set 8 04/30/15, 11:19

  14. Nicole Hummel voted on patch set 8 CR +1 V +1 04/30/15, 11:19

  15. Jan Helke voted on patch set 8 CR +1 V +1 04/30/15, 11:27

  16. Anja Leichsenring commented on patch set 8 V -1 05/01/15, 11:14

    does not work as expected. The page title is changed on doubleclick, but neighter the page tree gets updated nor is the change persisted. A second click on the page module reveals the old title.
  17. Anja Leichsenring commented on patch set 8 05/01/15, 11:17

    this is only not working in page module. List Module is fine.
  18. Anja Leichsenring uploaded patch set 9 05/01/15, 12:09

  19. Nicole Hummel voted on patch set 9 CR +1 V +1 05/01/15, 12:33

  20. Anja Leichsenring voted on patch set 9 CR +2 V +2 05/01/15, 14:13

  21. Anja Leichsenring merged patch set 9 05/01/15, 14:13

  22. Markus Klein commented on patch set 10 05/01/15, 16:30

    Post -1

    PageActions.js:148

    completely useless closure! You can simply leave it out.

    PageActions.js:149

    Why do we put new modules into the global space again? That's just against the idea of AMD.