38372[BUGFIX] Allow "distinct" in select.selectFields
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Daniel Goerz +1
- Benni Mack +1
-
Verified V +2 Done
- Frank Nägler +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1215
-
Andreas Kienast uploaded patch set 1 03/31/15, 14:01
-
Xavier Perseguers commented on patch set 1 04/10/15, 07:13
This implies DISTINCT is the same as a SQL function, which is not the case, we write SELECT DISTINCT column and not SELECT DISTINCT(column) even if this is tolerated by MySQL -
Jo Hasenau commented on patch set 1 04/23/15, 11:14
@Xavier: so is this actually a -1 and we should change the expression, or was just meant as a FYI? -
Xavier Perseguers commented on patch set 1 CR -1 04/23/15, 11:44
Yes in fact I'd like it to be correct. Possibly allow both syntaxes for people having no clue but for sure not forcing to use it as a function -
Andreas Kienast abandoned the change 09/22/15, 12:11
-
Susi Moog restored the change 03/05/20, 08:18
-
Susi Moog uploaded patch set 2 03/05/20, 08:18
-
TYPO3com voted on patch set 2 V -1 03/05/20, 08:33 Completed build in 14m 52s on Thu, 5 Mar, 08:33 AM Test Summary: 72119 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-983
-
TYPO3com voted on patch set 2 V +1 03/05/20, 11:33 Completed build in 3h 29m 38s on Thu, 5 Mar, 11:33 AM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-983
-
Susi Moog uploaded patch set 3 03/05/20, 13:32
-
TYPO3com voted on patch set 3 V +1 03/05/20, 13:42 Completed build in 10m 19s on Thu, 5 Mar, 01:42 PM Test Summary: 72123 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-987
-
Benni Mack voted on patch set 3 V +1 CR +1 03/06/20, 09:07
-
Daniel Goerz voted on patch set 3 CR +1 03/06/20, 09:37
-
Frank Nägler voted on patch set 3 V +2 CR +2 03/06/20, 12:36
-
Frank Nägler merged patch set 4 03/06/20, 12:36