Review main Merged

38382[TASK] Make openid return script dispatched

Wouter Wolters CR +2 V +2 Easy +39 −5 updated 04/22/15, 19:11

Commit message

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Markus Klein +1
  • Verified V +2
    • Jigal van Hemert +2
    • Markus Klein +1

Issues 1

Files 5

Review log 11

  1. Wouter Wolters uploaded patch set 1 03/31/15, 17:25

  2. Wouter Wolters uploaded patch set 2 03/31/15, 17:28

  3. Markus Klein commented on patch set 2 03/31/15, 17:37

    OpenidService.php:409

    can be combined

    OpenidService.php:415

    can be shortened
  4. Jigal van Hemert uploaded patch set 3 03/31/15, 18:51

  5. Jigal van Hemert voted on patch set 3 CR +1 V +1 03/31/15, 18:52

  6. Markus Klein updated the commit message in patch set 4 03/31/15, 18:56

  7. Markus Klein commented on patch set 4 CR +1 V +1 03/31/15, 18:58

    I just noticed that the wizard has different heights in user settings and from be_user, but that is of course unrelated.
  8. Jigal van Hemert commented on patch set 4 CR +2 V +2 03/31/15, 19:27

    Only commit message changed, keeping my votes.
  9. Jigal van Hemert merged patch set 4 03/31/15, 19:27

  10. Markus Klein commented on patch set 5 04/13/15, 14:22

  11. Markus Klein commented on patch set 5 04/22/15, 19:11

    my comment applies to the regression

    index.php:16

    This is plain wrong here! This needs to happen before we bootstrap!!