Review main Merged

38413[BUGFIX] Do not fix uniqueInPid for empty values

Markus Klein CR +2 V +2 Easy +17 −15 updated 04/01/15, 20:15

Commit message

This patch adds the necessary condition to avoid creating useless
values in fields that have eval=uniqueInPid.
The behaviour is triggered when moving records around in BE.

This empty-check is already present in other places, but was
obviously forgotten to be added to fixUniqueInPid().

Review

  • Code review CR +2
    • Markus Klein +2
    • Jo Hasenau +1
    • Andreas Kienast +1
  • Verified V +2
    • Markus Klein +2
    • Jo Hasenau +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 5

  1. Markus Klein uploaded patch set 1 04/01/15, 16:04

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 04/01/15, 17:53

  3. Jo Hasenau voted on patch set 1 V +1 CR +1 04/01/15, 19:30

  4. Markus Klein commented on patch set 1 CR +2 V +2 04/01/15, 20:14

    Thanks guys!
  5. Markus Klein merged patch set 1 04/01/15, 20:15