Review main Merged

38415[BUGFIX] Fix return URL in OpenID wizard

Jigal van Hemert CR +2 V +2 Normal +43 −44 updated 04/02/15, 13:32

Commit message

The URL must be absolute and the parameters are cleaned up.
The returnURL sent to the OpenID provider must match the trusted
domain so it must be an absolute URL.

The code of the wizard is cleaned as well and also the closing curly
brace of a fluid translate viewhelper call is added.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Markus Klein +1
  • Verified V +2
    • Jigal van Hemert +2
    • Markus Klein +1

Issues 1

Files 5

Review log 12

  1. Jigal van Hemert uploaded patch set 1 04/01/15, 17:59

  2. Markus Klein commented on patch set 1 CR -1 04/01/15, 18:02

    Wizard.php:101

    Does not work when instance is in a subdirectory, this is duplicated now. http://kleindev/master/master/typo3...
  3. Markus Klein uploaded patch set 2 04/02/15, 12:52

  4. Markus Klein voted on patch set 2 CR +1 V +1 04/02/15, 13:00

  5. Jigal van Hemert commented on patch set 2 V +1 CR +1 04/02/15, 13:01

    Votes for Markus' changes. Need a final vote for the combined changes.
  6. Wouter Wolters voted on patch set 2 CR +1 04/02/15, 13:03

  7. Markus Klein voted on patch set 2 CR -1 04/02/15, 13:05

  8. Markus Klein voted on patch set 2 V -1 04/02/15, 13:06

  9. Markus Klein uploaded patch set 3 04/02/15, 13:15

  10. Markus Klein voted on patch set 3 CR +1 V +1 04/02/15, 13:16

  11. Jigal van Hemert commented on patch set 3 CR +2 V +2 04/02/15, 13:32

    Markus' changes are now way more than the original small patch. Therefore my votes count as if I didn't make the first patch set.
  12. Jigal van Hemert merged patch set 3 04/02/15, 13:32