38422[FEATURE] Add SVG support
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
- Benjamin Kott +1
-
Verified V +2
- Wouter Wolters +2
- Benjamin Kott +1
Issues 1
Files 17
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+4 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+6 −4
- typo3/sysext/backend/Classes/Form/Element/InlineElement.php2+7 −3
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+10 −6
- typo3/sysext/backend/Classes/Utility/IconUtility.php+4 −0
- typo3/sysext/core/Classes/Resource/Hook/FileInfoHook.php+4 −1
- typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php2+66 −11
- typo3/sysext/core/Classes/Resource/Processing/LocalImageProcessor.php+10 −1
- typo3/sysext/core/Classes/Resource/Processing/LocalPreviewHelper.php2+27 −3
- typo3/sysext/core/Classes/Resource/ProcessedFile.php+6 −4
- typo3/sysext/core/Classes/Type/File/ImageInfo.php2+30 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-50136-AddSVGSupport.rst7new+18 −0
- typo3/sysext/filelist/Classes/FileList.php+4 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+4 −3
- typo3/sysext/frontend/Classes/Controller/ShowImageController.php+4 −2
- typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php+7 −3
Review log 30
Show 5 earlier messages
-
Frans Saris uploaded patch set 1 04/01/15, 20:33
-
Benjamin Kott commented on patch set 1 V -1 04/01/15, 21:14
Great work so far, but ive also encountered some issues. - PDF are delivered to the frontend and preview missing - AI are delivered to the frontend and preview missing (not sure if it worked before) - SVG previews are not shown in irre relations (fal) intentional? -
Frans Saris uploaded patch set 2 04/02/15, 19:53
-
Frans Saris commented on patch set 2 04/03/15, 18:26
Needs a rebase after https://review.typo3.org/#/c/38468/ is in. Moves some of these changes to a different patch -
Benjamin Kott commented on patch set 2 V -1 04/03/15, 18:26
Filelist: preview images missing for .ai, pdf Edit Metadata: preview images missing for .ai, .pdf Page Module: preview images missing for .ai, .pdf, .svg Edit Record (FAL): preview images missing for .ai, .pdf, .svg Frontend Rendering (with responsive images): Images missing for .ai, .pdf, .svg
-
Benjamin Kott commented on patch set 2 04/03/15, 18:27
Filelist: preview images missing for .ai, pdf Edit Metadata: preview images missing for .ai, .pdf Page Module: preview images missing for .ai, .pdf, .svg Edit Record (FAL): preview images missing for .ai, .pdf, .svg Frontend Rendering (with responsive images): Images missing for .ai, .pdf, .svg -
Frans Saris uploaded patch set 3 04/03/15, 20:02
-
Benjamin Kott commented on patch set 3 CR +1 V +1 04/03/15, 20:18
looks good - awesome! -
Wouter Wolters voted on patch set 3 CR +1 04/03/15, 20:24
-
Frans Saris commented on patch set 3 04/03/15, 20:33
This changes needs to be merged first https://review.typo3.org/#/c/38468/ . Reviews welcome :) -
Benjamin Kott uploaded patch set 4 04/04/15, 15:00
-
Benjamin Kott commented on patch set 4 CR +1 V +1 04/04/15, 15:00
rebase -
Benjamin Kott uploaded patch set 5 04/04/15, 15:07
-
Frans Saris uploaded patch set 6 04/08/15, 10:03
-
Frans Saris commented on patch set 6 04/08/15, 10:06
You can test this by uploading an SVG file and then look at the <img tag in FE output, or in the BE previews. The src should point to the original file and width + height should be set. -
Benjamin Kott voted on patch set 6 CR +1 V +1 04/08/15, 19:14
-
Benjamin Kott commented on patch set 6 04/08/15, 19:23
Testimages http://1drv.ms/1CVJu7o -
Markus Klein commented on patch set 6 04/08/15, 19:35
Great. Rendering width/height now explicitly also speeds up the rendering in browser as it already knows the image dimensions upfront.the or aAn extraInlineElement.php:620Is there no better way to detect if the processing was successful? This relies on width not being available in case blu blab happened.LocalCropScaleMaskHelper.php:218multiply first and divide at the end to gain maximum precision.LocalPreviewHelper.php:44Please document what is returned in the arrayImageInfo.php:79to find or to set?Feature-50136-AddSVGSupport.rst:8anFeature-50136-AddSVGSupport.rst:10image,Feature-50136-AddSVGSupport.rst:12An extraFeature-50136-AddSVGSupport.rst:12word missing -
Frans Saris commented on patch set 6 04/09/15, 06:57
InlineElement.php:620Replycurrently there is no better way. Is something for when the whole file processing is re-done/refactored. Will for now adjust the comment.LocalCropScaleMaskHelper.php:218ReplyDoneLocalPreviewHelper.php:44ReplyDoneImageInfo.php:79ReplyDoneFeature-50136-AddSVGSupport.rst:8ReplyDoneFeature-50136-AddSVGSupport.rst:10ReplyDoneFeature-50136-AddSVGSupport.rst:12ReplyDone -
Frans Saris uploaded patch set 7 04/09/15, 06:57
-
Markus Klein voted on patch set 7 CR +1 04/09/15, 10:00
-
Benjamin Kott voted on patch set 7 CR +1 V +1 04/09/15, 19:28
-
Wouter Wolters voted on patch set 7 CR +1 04/09/15, 20:12
-
Wouter Wolters voted on patch set 7 V +2 CR +2 04/09/15, 20:42
-
Wouter Wolters merged patch set 7 04/09/15, 20:42
-
Felix Kopp commented on patch set 8 04/09/15, 21:01
Works well! ElementInfo, TCA, List, Preview, IRRE preview :) -
Felix Kopp commented on patch set 8 04/09/15, 21:02
In Page module the tt_content image might break the column width since the width is show, no problem -
Frans Saris commented on patch set 8 04/10/15, 06:05
@Felix, do not think that would break column width as the images just jumpt to a new line when if they do not fit. Or do you mean something else? -
Felix Kopp commented on patch set 8 04/10/15, 08:42
Hi Frans, please see the screenshot at https://forge.typo3.org/issues/50136#note-15. I guess caused by the width/height parameters and missing img-responsive CSS class in page module? -
Frans Saris commented on patch set 8 04/10/15, 09:35
that shouldn't happen. In the other views the width/height are set correct? Irre, elementInformation etc. The width/height should be max 150x150