38449[TASK] Remove gradient from DocHeader
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Benjamin Kott +1
-
Verified V +2
- Anja Leichsenring +2
- Benjamin Kott +1
Issues 1
Files 4
Review log 14
-
Frank Nägler uploaded patch set 1 04/02/15, 21:15
-
Benjamin Kott commented on patch set 1 V -1 04/04/15, 12:01
background on collapsed pagetree has to be white and the docheader needs to continue -
Frank Nägler commented on patch set 1 CR -1 04/04/15, 14:01
on it -
Frank Nägler uploaded patch set 2 04/04/15, 14:24
-
Frank Nägler uploaded patch set 3 04/04/15, 14:38
-
Frank Nägler uploaded patch set 4 04/04/15, 14:40
-
Benjamin Kott voted on patch set 4 CR +1 V +1 04/04/15, 14:49
-
Anja Leichsenring voted on patch set 4 CR +2 V +2 04/04/15, 15:09
-
Anja Leichsenring merged patch set 4 04/04/15, 15:09
-
Felix Kopp commented on patch set 5 04/04/15, 23:22
Post -2 + No arguments for removal + Not discussed / documented before hand This is a special elements with special markup. Revert required. Please supply the concept for the doc header before stripping styling down. -
Frank Nägler commented on patch set 5 04/05/15, 08:35
Reasons for remove the gradient: - The DocHeader is the only element which contains a gradient. - Some people on the UXW ask: Why this element is different and ask for removing the gradient - The complete backend should follow a constant layout - The action icons in the DocHeader without gradient are better to recognize I think we have lot of reasons, why the gradient should be removed. -
Felix Kopp commented on patch set 5 04/07/15, 08:55
Hi Frank, thanks for the up, but I do not share these thoughts. Yes, the buttons must be reworked and become real buttons, but not by removing the background. The DocHeader is the most important section within the editing area. This element must and may receive a special layout/markup. Here communication goes over convention. Also the DocHeader is "above" the content area and must receive a clear level above the content. There are several possibilities: drop shadow or depth effect. The gradient can not be removed without propper replacement. Also the separating line is removed which is not communicated, there is no replacement or improvement. The section must be recovered. Still -2 and I opt for revert. -
Frank Nägler commented on patch set 5 04/07/15, 21:02
Hi Felix, a new layout is work in progress. Benji told me that he has ideas and maybe mockups!? Not sure yet. The Rework of the DocHeader is not so easy, that is the reason why we not get it into 7.2 The gradient does not fit the rest of the BE layout, we talked to a lot of people at the UXW, all these people opt for removing the gradient as first step. Regard the line: between the two bars, this is imo not really important, so I am fine if we add it again. but I opt for not revert the gradient. -
Felix Kopp commented on patch set 5 04/07/15, 21:19
Hi Frank, sorry but this does not convince me yet. Of course the rework is very important and the DocHeader an important core component. But especially with a complicated task there must be (rough) concept/goal defined. Plus the layout should not be voted on based on a first step. When this task can not be finished until release and the concept is not clear removing the foundation seems the wrong approach. This should not have gone into master.