Review main Merged

38485[BUGFIX] Respect access method with updater in EM

Jigal van Hemert CR +2 V +2 Easy +29 −4 updated 04/09/15, 22:49

Commit message

The Extension Manager checks the access method in each update
script when rendering the icon in the list of extensions.

Review

  • Code review CR +2
    • Markus Klein +2
    • Xavier Perseguers +1
  • Verified V +2
    • Markus Klein +2
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 19

  1. Jigal van Hemert uploaded patch set 1 04/04/15, 19:46

  2. Anja Leichsenring commented on patch set 1 04/04/15, 19:55

    UpdateScriptUtility.php:93

    I would like to keep the old name. This is a public function, by renaming you introduce a breaking change.
  3. Jigal van Hemert uploaded patch set 2 04/05/15, 13:30

  4. Xavier Perseguers commented on patch set 2 CR -1 04/07/15, 14:19

    My EM breaks with Fatal error: Class 'TYPO3\CMS\UpdateScript5523e76134873\TYPO3\CMS\Core\Utility\ExtensionManagementUtility' not found in /Users/xavier/Projects/TYPO3-Core/TYPO3_master/typo3/sysext/extensionmanager/Classes/Utility/UpdateScriptUtility.php(111) : eval()'d code on line 126
  5. Xavier Perseguers commented on patch set 2 CR +1 V +1 04/07/15, 14:29

    This happens with ig_ldap_sso_auth because I actually miss a backslash in a call which worked before because there were no namespaces.
  6. Xavier Perseguers commented on patch set 2 04/07/15, 14:31

    I suspect PhpStorm from having "badly" auto-completed: https://review.typo3.org/#/c/38512/1/class.ext_update.php
  7. Markus Klein commented on patch set 2 CR -1 V -1 04/07/15, 22:20

    The namespace magic does not work. Consider an update class that uses PHP root level classes like Exception. Mostly Exception will be used without leading backslash, since the class assumes to be in global space and this is perfectly fine. But with the artificial namespace this fails, because now the usage must be \Exception. I doubt this can be solved in a sane way.

    UpdateScriptUtility.php:103

    why not a simple str_replace?
  8. Xavier Perseguers commented on patch set 2 CR -1 04/08/15, 04:33

    Problem spotted by Markus is in fact what I had with my first test, where I used a class from TYPO3 Core without referring to it with a leading backslash. Thus adding a namespace is in fact possibly not the best solution.

    UpdateScriptUtility.php:114

    please extend exception message with the actual name of the faulty extension, this will highly ease debugging.
  9. Jigal van Hemert abandoned the change 04/08/15, 09:52

  10. Xavier Perseguers restored the change 04/08/15, 14:15

    Don't get why it was abandoned so soon
  11. Xavier Perseguers uploaded patch set 3 04/08/15, 14:15

  12. Xavier Perseguers voted on patch set 3 CR +1 V +1 04/08/15, 14:25

  13. Markus Klein commented on patch set 3 CR +1 04/08/15, 14:44

    looks good
  14. Markus Klein commented on patch set 3 04/09/15, 15:17

    A candidate for 6.2 too?
  15. Xavier Perseguers updated the commit message in patch set 4 04/09/15, 15:18

  16. Xavier Perseguers voted on patch set 4 CR +1 V +1 04/09/15, 15:19

  17. Markus Klein voted on patch set 4 CR +1 V +1 04/09/15, 15:19

  18. Markus Klein voted on patch set 4 CR +2 V +2 04/09/15, 22:49

  19. Markus Klein merged patch set 4 04/09/15, 22:49