38486[TASK] Refactor util.js to AMD module
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Wouter Wolters +1
-
Verified V +2
- Andreas Kienast +2
- Wouter Wolters +1
Issues 1
Files 3
Review log 7
-
Frank Nägler uploaded patch set 1 04/04/15, 20:54
-
Wouter Wolters commented on patch set 1 CR -1 04/05/15, 14:07
Isn;t it maybe better to move the functions to the scripts where they are needed?codemirror.js:38why remove, this is a file of codemirror itself.Utility.js:34If I search this function it is only used once in sysext/backend/Resources/Public/JavaScript/extjs/components/pagetree/javascript/toppanel.jsUtility.js:45only used once in sysext/backend/Resources/Public/JavaScript/extjs/components/pagetree/javascript/actions.js -
Frank Nägler commented on patch set 1 CR -1 04/05/15, 17:19
If we move the methods into the according JS-Files, we have a breaking change in case an extension use the methods. I think we should move it like in this patch. Will send a new patchset for the codemirror.js mistake.codemirror.js:38ReplyYou are right, my mistake. -
Frank Nägler uploaded patch set 2 04/05/15, 17:20
-
Wouter Wolters voted on patch set 2 V +1 CR +1 05/03/15, 12:38
-
Andreas Kienast voted on patch set 2 CR +2 V +2 05/03/15, 12:55
-
Andreas Kienast merged patch set 2 05/03/15, 12:55