Review main Merged

38487[FEATURE] Added ActionMenuItemGroupViewHelper

Michael Oehlhof CR +2 V +2 Normal +96 −1 updated 05/02/15, 18:24

Commit message

Using this ViewHelper we can use OptGroups in the backend selectfield
which controls which function selected.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Andreas Kienast +1
  • Verified V +2
    • Frank Nägler +2
    • Andreas Kienast +1

Issues 1

Files 3

Review log 26

Show 1 earlier messages
  1. Michael Oehlhof uploaded patch set 1 04/04/15, 22:38

  1. Anja Leichsenring commented on patch set 1 04/05/15, 11:14

    please add a documentation file and provide usage hints in the doc header of the class. Reference to the other viewhelper files for examples.
  2. Michael Oehlhof uploaded patch set 2 04/05/15, 12:59

  3. Anja Leichsenring commented on patch set 2 04/05/15, 13:21

    way better, thank you :) Review in progress.
  4. Anja Leichsenring voted on patch set 2 CR +1 V +1 04/05/15, 13:47

  5. Wouter Wolters commented on patch set 2 CR -1 04/05/15, 14:12

    on it
  6. Wouter Wolters uploaded patch set 3 04/05/15, 14:15

  7. Wouter Wolters voted on patch set 3 CR +1 04/05/15, 14:15

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 04/05/15, 14:17

  9. Michael Oehlhof voted on patch set 3 CR +1 V +1 04/05/15, 18:29

  10. Frank Nägler commented on patch set 3 CR -1 05/02/15, 15:04

    ActionMenuItemGroupViewHelper.php:38

    imo we could implement the CompilableInterface here too

    ActionMenuItemGroupViewHelper.php:53

    Imo it would make sense to check here for instanceof ActionMenuItemViewHelper instead of ViewHelperNode, because other sub elements could and should not be rendered in this context.
  11. Michael Oehlhof commented on patch set 3 05/02/15, 16:53

    ActionMenuItemGroupViewHelper.php:38 Reply

    I think this should be another item, because ActionMenuViewHelper and ActionMenuItemViewHelper also have to implement the CompilableInterface.
  12. Michael Oehlhof uploaded patch set 4 05/02/15, 16:53

  13. Michael Oehlhof uploaded patch set 5 05/02/15, 17:16

  14. Frank Nägler commented on patch set 5 CR -1 05/02/15, 17:21

    Default.html:11

    please remove your test setup form patch ;)

    ActionMenuItemGroupViewHelper.php:54

    why not check directly agains ActionMenuItemViewHelper ? Imo the double if is not needed here.
  15. Michael Oehlhof uploaded patch set 6 05/02/15, 17:46

  16. Michael Oehlhof commented on patch set 5 05/02/15, 17:48

    ActionMenuItemGroupViewHelper.php:54 Reply

    Because $childNode is an instance ViewHelperNode. If I check against ActionMenuItemViewHelper nothing is rendered.
  17. Frank Nägler commented on patch set 6 CR -1 05/02/15, 18:03

    on it, will push a new set shortly
  18. Frank Nägler uploaded patch set 7 05/02/15, 18:07

  19. Frank Nägler uploaded patch set 8 05/02/15, 18:08

  20. Frank Nägler commented on patch set 8 V +1 CR +1 05/02/15, 18:10

    now I am fine :) I have removed the second if statement and use here also the ::class feature instead of a static string. thx for your patch.
  21. Andreas Kienast uploaded patch set 9 05/02/15, 18:14

  22. Andreas Kienast commented on patch set 9 05/02/15, 18:14

    Can we make this VH compilable?
  23. Andreas Kienast commented on patch set 9 V +1 CR +1 05/02/15, 18:19

    I talked to Frank, let's do this in a followup.
  24. Frank Nägler voted on patch set 9 V +2 CR +2 05/02/15, 18:24

  25. Frank Nägler merged patch set 9 05/02/15, 18:24