Review main Merged Breaking

38516[!!!][TASK] Rewrite ValueSlider to AMD module

Wouter Wolters CR +2 V +2 Hard +625 −140 updated 05/17/15, 05:55

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Markus Klein +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Klein +1

Issues 1

Files 11

Review log 34

Show 9 earlier messages
  1. Wouter Wolters uploaded patch set 1 04/07/15, 16:27

  2. Benni Mack commented on patch set 1 04/07/15, 19:14

    hey wouter, they use the apache license which does not suit our GPLv2+ license nicely. Could you ask them via github if they could switch to MIT?
  3. Andreas Kienast uploaded patch set 2 04/28/15, 12:03

  4. Andreas Kienast uploaded patch set 3 05/05/15, 11:05

  5. Andreas Kienast commented on patch set 3 05/05/15, 11:05

    rebased and updated the library to 4.8.1, being GPL2 compatible
  6. Andreas Kienast uploaded patch set 4 05/05/15, 13:47

  7. Andreas Kienast uploaded patch set 5 05/15/15, 13:07

  8. Andreas Kienast commented on patch set 5 05/15/15, 13:08

    rebased
  9. Andreas Kienast uploaded patch set 6 05/15/15, 14:18

  1. Andreas Kienast uploaded patch set 7 05/16/15, 09:28

  2. Benjamin Kott uploaded patch set 8 05/16/15, 14:36

  3. Benjamin Kott uploaded patch set 9 05/16/15, 14:42

  4. Andreas Kienast uploaded patch set 10 05/16/15, 15:05

  5. Andreas Kienast uploaded patch set 11 05/16/15, 15:07

  6. Andreas Kienast uploaded patch set 12 05/16/15, 15:09

  7. Benjamin Kott voted on patch set 12 CR +1 V +1 05/16/15, 15:22

  8. Frank Nägler voted on patch set 12 CR +1 05/16/15, 15:28

  9. Markus Klein commented on patch set 12 05/16/15, 15:32

    ValueSlider.js:80

    why having a global object for this?
  10. Frank Nägler commented on patch set 12 V -1 05/16/15, 15:33

    Problem with INPUT: 35 Slider wizard, hideParent (from EXT:styleguide). The value in hidden fields are updated, but not in the the visible and disabled field.
  11. Frank Nägler commented on patch set 12 V +1 CR -1 05/16/15, 15:47

    please see Markus comment, I think the remark is valid, we don't need it in the global namespace.
  12. Andreas Kienast uploaded patch set 13 05/16/15, 17:30

  13. Frank Nägler voted on patch set 13 V +1 CR +1 05/16/15, 17:46

  14. Markus Klein commented on patch set 13 05/16/15, 18:02

    sorry one more thing, which makes the code more easy to read.

    ValueSlider.js:76

    Why are we walking through all jquery objects with .each(), then we pass the DOM element to the method and there we build the jQuery object again?? Only call ValueSlider.initializeSlider() here and do this in then init function: $('[data-slider-id]').slider({...}).on('slide', ValueSlider.updateValue);
  15. Markus Klein commented on patch set 13 05/16/15, 18:02

    will push an update
  16. Markus Klein commented on patch set 13 CR +1 V +1 05/16/15, 18:13

    ValueSlider.js:24

    seems like we have to do this, because the library does not bind "this" for the callback... dumb thing.
  17. Frank Nägler commented on patch set 13 CR -2 05/16/15, 19:06

    will come up with a new solution
  18. Markus Klein voted on patch set 13 CR 0 V 0 05/16/15, 19:17

  19. Frank Nägler uploaded patch set 14 05/16/15, 19:18

  20. Frank Nägler voted on patch set 14 V +1 CR +1 05/16/15, 19:19

  21. Markus Klein uploaded patch set 15 05/16/15, 19:23

  22. Markus Klein voted on patch set 15 CR +1 V +1 05/16/15, 19:27

  23. Frank Nägler voted on patch set 15 V +2 CR +2 05/16/15, 19:28

  24. Frank Nägler merged patch set 15 05/16/15, 19:28

  25. Andreas Kienast commented on patch set 16 05/17/15, 05:55

    Post -1, the tooltip does not reflect the value in <select> tags anymore.