38617[TASK] Travis CI: Run PHP_LINT at first
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 8
-
Andreas Kienast uploaded patch set 1 04/10/15, 09:50
-
Andreas Kienast updated the commit message in patch set 2 04/10/15, 09:51
-
Andreas Kienast updated the commit message in patch set 3 04/10/15, 09:51
-
Nicole Hummel voted on patch set 3 CR +1 04/10/15, 10:02
-
Stephan Großberndt voted on patch set 3 CR +1 04/10/15, 10:31
-
Christian Kuhn commented on patch set 3 04/10/15, 10:49
I don't care too much, but the reason for having the unit tests first were: * unit tests are most likely to fail from the group of unit/functional/lint/xlf tests, so you get this info early, then. * the linter takes some time (more than unit testing) and it depends heavily on which other tasks are executed on the same hardware at the tims, so it also has a high bandwith in time, while unit tests are relatively stable in execution time * linting usually does not fail - we usually manage to merge only compilable stuff ;) -
Stephan Großberndt commented on patch set 3 CR 0 04/13/15, 14:00
Makes sense, Christian. Thanks for the explanation. Abandon? -
Andreas Kienast abandoned the change 04/13/15, 14:56